Re: [PATCH v6 5/9] watchdog: bindings: Provide ST bindings for ST's LPC Watchdog device

[Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>]

On 03/24/2015 02:25 AM, Lee Jones wrote:
> On current ST platforms the LPC controls a number of functions including
> Watchdog and Real Time Clock.  This patch provides the bindings used to
> configure LPC in Watchdog mode.
>
> Signed-off-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>   .../devicetree/bindings/watchdog/st_lpc_wdt.txt    | 38 ++++++++++++++++++++++
>   1 file changed, 38 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> new file mode 100644
> index 0000000..1bdf023
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/st_lpc_wdt.txt
> @@ -0,0 +1,38 @@
> +STMicroelectronics Low Power Controller (LPC) - Watchdog
> +========================================================
> +
> +LPC currently supports Watchdog OR Real Time Clock functionality.
> +
> +[See: ../rtc/rtc-st-lpc.txt for RTC options]
> +
> +Required properties
> +
> +- compatible 	: Must be one of: "st,stih407-lpc" "st,stih416-lpc"
> +				  "st,stih415-lpc" "st,stid127-lpc"
> +- reg		: LPC registers base address + size
> +- interrupts    : LPC interrupt line number and associated flags
> +- clocks	: Clock used by LPC device (See: ../clock/clock-bindings.txt)
> +- st,lpc-mode	: The LPC can run either one of two modes ST_LPC_MODE_RTC [0] or
> +		  ST_LPC_MODE_WDT [1].  One (and only one) mode must be
> +		  selected.
> +
> +Required properties [watchdog mode]
> +
> +- st,syscfg	: Phandle to syscfg node used to enable watchdog and configure
> +		  CPU reset type.
> +- timeout-sec	: Watchdog timeout in seconds
> +
> +Optional properties [watchdog mode]
> +
> +- st,warm-reset	: If present reset type will be 'warm' - if not it will be cold
> +
> +Example:
> +	lpc@fde05000 {
> +		compatible	= "st,stih416-lpc-watchdog";

Hi Lee,

Just noticed: That doesn't match the above description, nor the match statement
in the drivers.

Guenter


> +		reg		= <0xfde05000 0x1000>;
> +		clocks 		= <&clk_s_d3_flexgen CLK_LPC_0>;
> +		st,syscfg	= <&syscfg_core>;
> +		timeout-sec	= <120>;
> +		st,lpc-mode	= <ST_LPC_MODE_WDT>;
> +		st,warm-reset;
> +	};
>

--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html