From: Kishon Vijay Abraham I <kishon@ti.com>
To: Dmitry Torokhov <dtor@google.com>
Cc: Arun Ramamurthy <arun.ramamurthy@broadcom.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Arnd Bergmann <arnd@arndb.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Anatol Pomazau <anatol@google.com>,
Jonathan Richardson <jonathar@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Ray Jui <rjui@broadcom.com>, Dmitry Torokhov <dtor@chromium.org>
Subject: Re: [PATCH v1 1/3] phy: phy-core: allow specifying supply at port level
Date: Thu, 26 Mar 2015 04:09:23 +0530 [thread overview]
Message-ID: <5513391B.2060505@ti.com> (raw)
In-Reply-To: <CAE_wzQ_8YzZwizyozU-0MPLX8-hT1Y1LnfYFg+iEvQgYX7zjFg@mail.gmail.com>
Hi,
On Thursday 26 March 2015 03:47 AM, Dmitry Torokhov wrote:
> On Wed, Mar 25, 2015 at 3:11 PM, Kishon Vijay Abraham I <kishon@ti.com> wrote:
>> Hi,
>>
>> On Saturday 21 March 2015 02:55 AM, Arun Ramamurthy wrote:
>>> Multi-port phy's may have per-port power supplies. Let's change phy core
>>> to first attempt to look up the supply at the port level, and then, if
>>> not found, check parent device.
>>
>> Why not just have every port provide the power supply if it needs?
>> I don't think checking for parent device should be present in the phy-core at
>> all.
>
> We need to do that if we want to keep compatibility with the current
> DTSes: before this patch the supply would be always looked up on
> device and not port level.
ah okay.
so just using regulator_get_optional(&phy->dev, "phy"); should be sufficient
right? Why do we need regulator_get_optional(phy->dev.parent, "phy");?
Thanks
Kishon
next prev parent reply other threads:[~2015-03-25 22:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 21:25 [PATCH v1 0/3] USB PHY driver for Broadcom's Cygnus chipse Arun Ramamurthy
2015-03-20 21:25 ` [PATCH v1 1/3] phy: phy-core: allow specifying supply at port level Arun Ramamurthy
2015-03-20 21:31 ` Dmitry Torokhov
2015-03-25 22:11 ` Kishon Vijay Abraham I
2015-03-25 22:17 ` Dmitry Torokhov
2015-03-25 22:39 ` Kishon Vijay Abraham I [this message]
[not found] ` <5513391B.2060505-l0cyMroinI0@public.gmane.org>
2015-03-25 22:49 ` Dmitry Torokhov
2015-03-25 23:44 ` Kishon Vijay Abraham I
2015-03-25 23:48 ` Dmitry Torokhov
[not found] ` <1426886727-537-1-git-send-email-arun.ramamurthy-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-20 21:25 ` [PATCH v1 2/3] Phy: DT binding documentation for Broadcom Cygnus USB PHY driver Arun Ramamurthy
[not found] ` <1426886727-537-3-git-send-email-arun.ramamurthy-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-25 22:16 ` Kishon Vijay Abraham I
2015-03-26 0:04 ` Arun Ramamurthy
2015-03-26 23:02 ` Dmitry Torokhov
2015-03-20 21:25 ` [PATCH v1 3/3] phy: cygnus-usbphy: Add Broadcom Cygnus USB phy driver Arun Ramamurthy
[not found] ` <1426886727-537-4-git-send-email-arun.ramamurthy-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-25 22:28 ` Kishon Vijay Abraham I
2015-03-25 22:42 ` Dmitry Torokhov
2015-03-26 0:01 ` Kishon Vijay Abraham I
2015-03-26 0:06 ` Arun Ramamurthy
[not found] ` <55134D73.7060507-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-31 6:16 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513391B.2060505@ti.com \
--to=kishon@ti.com \
--cc=anatol@google.com \
--cc=arnd@arndb.de \
--cc=arun.ramamurthy@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=dtor@chromium.org \
--cc=dtor@google.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonathar@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rjui@broadcom.com \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).