From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH RESEND] ARM: dts: OMAP3-N900: Add microphone bias voltages Date: Mon, 30 Mar 2015 20:45:08 +0300 Message-ID: <55198BA4.5010207@bitmer.com> References: <1425236828-28349-1-git-send-email-jarkko.nikula@bitmer.com> <55197A12.1050009@bitmer.com> <20150330164237.GJ10805@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150330164237.GJ10805@atomide.com> Sender: linux-omap-owner@vger.kernel.org To: Tony Lindgren Cc: devicetree@vger.kernel.org, linux-omap@vger.kernel.org, =?windows-1252?Q?Beno=EEt_Cousson?= , Pavel Machek List-Id: devicetree@vger.kernel.org On 03/30/2015 07:42 PM, Tony Lindgren wrote: > * Jarkko Nikula [150330 09:31]: >> On 03/01/2015 09:07 PM, Jarkko Nikula wrote: >>> From: Pavel Machek >>> >>> N900 audio recording needs that codec provides bias voltage for integrated >>> digital microphone and headset microphone depending which one is used. >>> Digital microphone uses 2 V bias and it comes from the codec A part. Codec >>> B part drives the headset microphone bias and that is set to 2.5 V. >>> >>> Signed-off-by: Pavel Machek >>> [Jarkko: Headset mic bias changed to 2 (2.5 V) as it was before commit >>> e2e8bfdf6157 ("ASoC: tlv320aic3x: Convert mic bias to a supply widget")] >>> Signed-off-by: Jarkko Nikula >>> --- >>> arch/arm/boot/dts/omap3-n900.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >> Ping? > > Oops sorry I have missed this one. This looks like a regression fix > for the v4.0-rc series? Should it be cc stable v3.16+ or something? > Well, there has been regression but finding exactly how far should the fix go didn't look instantly straightforward due all DT, codec driver mic bias etc changes and I ended up not cc'ing stable. But well, I guess first kernel where this commit makes sense is 3.16+ due commit f7d0f2a08567 ("ARM: dts: omap3-n900: Add sound support"). Although it applies on top of commit 14e3e295b2b9 ("ARM: dts: omap3-n900: Add TLV320AIC3X support") too (3.12+) but not before that. -- Jarkko