From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH 2/2] ARM: shmobile: r8a7790: add EtherAVB DT support Date: Tue, 31 Mar 2015 18:04:43 +0300 Message-ID: <551AB78B.4000506@cogentembedded.com> References: <1625400.M0MxPQybIy@wasted.cogentembedded.com> <8163383.0UU0Q5gsLE@wasted.cogentembedded.com> <20150331002113.GB16289@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150331002113.GB16289@verge.net.au> Sender: linux-sh-owner@vger.kernel.org To: Simon Horman Cc: linux-sh@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, devicetree@vger.kernel.org, magnus.damm@gmail.com, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hello. On 03/31/2015 03:21 AM, Simon Horman wrote: >> Define the generic R8A7790 part of the EtherAVB device node. > Please repost once this binding (and associated driver) has been accepted. OK, but will you merge patch #1? >> Based on original patch by Mitsuhiro Kimura . >> Signed-off-by: Sergei Shtylyov >> >> --- >> arch/arm/boot/dts/r8a7790.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> Index: renesas/arch/arm/boot/dts/r8a7790.dtsi >> =================================================================== >> --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi >> +++ renesas/arch/arm/boot/dts/r8a7790.dtsi >> @@ -626,6 +626,16 @@ >> status = "disabled"; >> }; >> >> + avb: ethernet@e6800000 { >> + compatible = "renesas,ravb-r8a7790"; I went the usual way here but I suspect that SoC part of the prop should be "-rcar-gen2" as we now have this IP core (as well as most of the others, except PFC) described in a common manual for the R-Car generation 2 SoCs. What do you think? WBR, Sergei