From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61528C76188 for ; Wed, 5 Apr 2023 14:19:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238585AbjDEOTc (ORCPT ); Wed, 5 Apr 2023 10:19:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238533AbjDEOSx (ORCPT ); Wed, 5 Apr 2023 10:18:53 -0400 Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90F08E7 for ; Wed, 5 Apr 2023 07:18:09 -0700 (PDT) Received: by mail-ed1-x530.google.com with SMTP id y4so141542579edo.2 for ; Wed, 05 Apr 2023 07:18:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680704285; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uISS19+jToFclMpkmnOdVAy0VsfR3V1lwv1Dgp6A6Qs=; b=KETD9SA21cYXTW3wGTtfIqmkh9EbGlvtBVYEtmrReMYTa7JuDxLz+xNMgArd0rQwQH qeIioRLanv393ffmZn+j0Q8uD4SquXdRia0mWSvwgHAtxBrngocGMrCLK5c1e2TUBY5t aS1N7PWXiMDw16N8Ye4PIcTd/SoQuCyri/ZXhWpooYWsIl3g5Pv6evnSZGqFkdFLWaU5 gcEithmdKWBnZUhLq7mqtnY5b6B5vWuf6fb48i6OaUepdYaDmNOpHtVBrKxqJo4Yqr4e IH1Fk+4omZPNJ51OigDbgPo6+DOCcBJ+Y00B70Y/yfJUqRlg5w8xtZWzZWSTg4O69meG EoNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680704285; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uISS19+jToFclMpkmnOdVAy0VsfR3V1lwv1Dgp6A6Qs=; b=dg28Bv9et1TTkmgx+/D1QPj7t+lflcC3sF9QfvzAA7WwiTiVkS3AVJe+bZxsfnEDAe yqahFfqAa3Qt9xrbUPhV4x5xj3tZgMqcLb0NdOqoer7pxFn4axPzqK1NCClsWGW0/qTD 1gV6/2eHJFd3xnsIQqMCLnG+8kZ1durZOBCiq4Ua3Way1lmqA7rphpVEjkLLTg+PzWRY 5pqvROO46Wv1CUBhYRPXS8/nYPqEdJiZYyO2q9BSDAC8MCxn+1Q7ck/noF9COojkBCdp bOsigCV4vaIGnCmqa8N/66dbWxWVdWYVxeGt+2MzHrhtW5mwZ4KumuenyKIhp1y9G+Y5 jtxA== X-Gm-Message-State: AAQBX9fBFvX0JqMeO6gZHmjUxnPkHzsPdoRDQKi2UvAzZLdHLV9UV4r4 IexNxjwBELa1Jv5qoAf5BTsMXQ== X-Google-Smtp-Source: AKy350bX8RcQwC6IbMilofBM5NBcNepluBhbWwjkG4immwGuxPDPAJ+V1iei0t9gdH/bRQLNv3ratA== X-Received: by 2002:a17:906:360e:b0:931:ce20:db8e with SMTP id q14-20020a170906360e00b00931ce20db8emr3059867ejb.51.1680704285073; Wed, 05 Apr 2023 07:18:05 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:3f:6b2:54cd:498e? ([2a02:810d:15c0:828:3f:6b2:54cd:498e]) by smtp.gmail.com with ESMTPSA id gv19-20020a1709072bd300b00931db712768sm7430424ejc.4.2023.04.05.07.18.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Apr 2023 07:18:04 -0700 (PDT) Message-ID: <551c67b1-8c74-4ed6-7319-b6bfbe44eb2a@linaro.org> Date: Wed, 5 Apr 2023 16:18:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v6 1/8] dt-bindings: usb: Add bindings for multiport properties on DWC3 controller Content-Language: en-US To: Krishna Kurapati PSSNV , Thinh Nguyen , Greg Kroah-Hartman , Philipp Zabel , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, quic_pkondeti@quicinc.com, quic_ppratap@quicinc.com, quic_wcheng@quicinc.com, quic_jackp@quicinc.com, quic_harshq@quicinc.com, ahalaney@redhat.com, quic_shazhuss@quicinc.com, Bjorn Andersson References: <20230405125759.4201-1-quic_kriskura@quicinc.com> <20230405125759.4201-2-quic_kriskura@quicinc.com> <63bfaa1e-c627-bfe1-0bef-d001dae41014@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 05/04/2023 16:15, Krishna Kurapati PSSNV wrote: > > > On 4/5/2023 7:31 PM, Krzysztof Kozlowski wrote: >> On 05/04/2023 14:57, Krishna Kurapati wrote: >>> Add bindings to indicate properties required to support multiport >>> on Snps Dwc3 controller. >>> >>> Suggested-by: Bjorn Andersson >>> Signed-off-by: Krishna Kurapati >>> --- >>> Link to v5: https://lore.kernel.org/all/20230310163420.7582-2-quic_kriskura@quicinc.com/ >> >> You did not test it at v4 and you got report for this. Your changelog in >> commit msg does not mention fixing it. >> >> It looks like you did not test it for the second time (or sixth time). >> >> Best regards, >> Krzysztof >> > Hi Krzysztof, > > I did do a dt_binding_check and I got the following result: > > kriskura@hu-kriskura-hyd:/local/mnt/workspace/krishna/skales2/skales/kernel$ > make DT_CHECKER_FLAGS=-m dt_binding_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/usb/snps,dwc3.yaml > HOSTCC scripts/basic/fixdep > HOSTCC scripts/dtc/dtc.o > HOSTCC scripts/dtc/flattree.o > HOSTCC scripts/dtc/fstree.o > HOSTCC scripts/dtc/data.o > HOSTCC scripts/dtc/livetree.o > HOSTCC scripts/dtc/treesource.o > HOSTCC scripts/dtc/srcpos.o > HOSTCC scripts/dtc/checks.o > HOSTCC scripts/dtc/util.o > LEX scripts/dtc/dtc-lexer.lex.c > YACC scripts/dtc/dtc-parser.tab.[ch] > HOSTCC scripts/dtc/dtc-lexer.lex.o > HOSTCC scripts/dtc/dtc-parser.tab.o > HOSTLD scripts/dtc/dtc > LINT Documentation/devicetree/bindings > invalid config: unknown option "max-spaces-inside-empty" for rule "brackets" > xargs: /usr/bin/yamllint: exited with status 255; aborting > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/phy/qcom,usb-snps-femto-v2.yaml: > ignoring, error in schema: properties: qcom,pre-emphasis-duration-bp > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/arm/vexpress-sysreg.yaml: > ignoring, error in schema: properties: gpio-controller > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml: > ignoring, error in schema: patternProperties: ^thermistor@: properties: > adi,excitation-current-nanoamp > /local/mnt/workspace/krishna/skales2/skales/kernel/Documentation/devicetree/bindings/iio/adc/adi,ad4130.yaml: > ignoring, error in schema: patternProperties: ^channel@([0-9a-f])$: > properties: adi,excitation-current-0-nanoamp All these are some errors, maybe coming from your schema, maybe from next. You can narrow the tests with DT_SCHEMA_FILES (as mentioned in guide). Best regards, Krzysztof