From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH v6 10/15] serial: stm32-usart: Add STM32 USART Driver Date: Tue, 07 Apr 2015 13:05:39 -0400 Message-ID: <55240E63.3040502@hurleysoftware.com> References: <1428424234-28572-1-git-send-email-mcoquelin.stm32@gmail.com> <1428424234-28572-11-git-send-email-mcoquelin.stm32@gmail.com> <55240B2C.3020102@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <55240B2C.3020102@suse.de> Sender: linux-gpio-owner@vger.kernel.org To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , Maxime Coquelin , u.kleine-koenig@pengutronix.de, geert@linux-m68k.org, Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl, andy.shevchenko@gmail.com, cw00.choi@samsung.com, Russell King , Daniel Lezcano , joe@perches.com Cc: Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-arch@vger.kerne List-Id: devicetree@vger.kernel.org Hi Andreas, On 04/07/2015 12:51 PM, Andreas F=C3=A4rber wrote: > Am 07.04.2015 um 18:30 schrieb Maxime Coquelin: >> This drivers adds support to the STM32 USART controller, which is a >> standard serial driver. >> >> Tested-by: Chanwoo Choi >> Reviewed-by: Peter Hurley >> Signed-off-by: Maxime Coquelin >> --- >> drivers/tty/serial/Kconfig | 17 + >> drivers/tty/serial/Makefile | 1 + >> drivers/tty/serial/stm32-usart.c | 735 ++++++++++++++++++++++++++++= +++++++++++ >> include/uapi/linux/serial_core.h | 3 + >> 4 files changed, 756 insertions(+) >> create mode 100644 drivers/tty/serial/stm32-usart.c > [...] >> diff --git a/drivers/tty/serial/stm32-usart.c b/drivers/tty/serial/s= tm32-usart.c >> new file mode 100644 >> index 0000000..4adc430 >> --- /dev/null >> +++ b/drivers/tty/serial/stm32-usart.c > [...] >> +#define DRIVER_NAME "stm32-usart" >> +#define STM32_SERIAL_NAME "ttyS" >=20 > I'm surprised no one has complained about ttyS yet. Doesn't that need= to > be unique, such as ttySTM (efm32 uses ttyefm), to avoid clashes betwe= en > serial drivers? ttyS was exclusive to the 8250 driver, I thought. As long as this platform doesn't support 8250 h/w, I don't care; and by the time this platform is ready for multiconfig, I'll have ttyS coexistence fixed. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html