From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: pavel@ucw.cz, sakari.ailus@iki.fi,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-leds@vger.kernel.org, linux-media@vger.kernel.org,
kyungmin.park@samsung.com, cooloney@gmail.com, rpurdie@rpsys.net,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties
Date: Wed, 08 Apr 2015 16:45:28 +0200 [thread overview]
Message-ID: <55253F08.3040409@samsung.com> (raw)
In-Reply-To: <552517DD.2040905@samsung.com>
Hi Jacek,
On 08/04/15 13:58, Jacek Anaszewski wrote:
>>> --- a/Documentation/devicetree/bindings/leds/common.txt
>>> >> +++ b/Documentation/devicetree/bindings/leds/common.txt
>>> >> @@ -29,13 +29,15 @@ Optional properties for child nodes:
>>> >> "ide-disk" - LED indicates disk activity
>>> >> "timer" - LED flashes at a fixed, configurable rate
>>> >>
>>> >> -- max-microamp : maximum intensity in microamperes of the LED
>>> >> - (torch LED for flash devices)
>>> >> -- flash-max-microamp : maximum intensity in microamperes of the
>>> >> - flash LED; it is mandatory if the LED should
>>> >> - support the flash mode
>>> >> -- flash-timeout-us : timeout in microseconds after which the flash
>>> >> - LED is turned off
>>> >> +- max-microamp : Maximum intensity in microamperes of the LED
>>> >> + (torch LED for flash devices). If omitted this will default
>>> >> + to the maximum current allowed by the device.
>>> >> +- flash-max-microamp : Maximum intensity in microamperes of the flash LED.
>>> >> + If omitted this will default to the maximum
>>> >> + current allowed by the device.
>>> >> +- flash-timeout-us : Timeout in microseconds after which the flash
>>> >> + LED is turned off. If omitted this will default to the
>>> >> + maximum timeout allowed by the device.
>> >
>> > Sorry about late comments on that, but since we can still change these
>> > properties and it seems we're going to do that, I'd like throw in my
>> > few preferences on the colour of this bike...
>> >
>> > IMO "max-microamp" is a poor property name, how about:
>> >
>> > s/max-microamp/led-max-current-ua,
>> > s/flash-max-microamp/flash-max-current-ua,
>> >
>> > so we have more consistent set of properties like:
>> >
>> > led-max-current-ua
>> > flash-max-current-ua
>> > flash-timeout-us
>
> The "-microamp' suffix is consistent with regulator bindings.
> Please refer to [1].
OK, in a perfect world we would have clean and consistent notation of
units. If it's acked let's leave it, I didn't know it was, sorry about
that.
When I read yesterday Documentation/devicetree/bindings/leds/common.txt
the set of new properties looked rather sloppy, especially "max-microamp"
looked incomplete to me, as if the subject was missing.
Anyway, I'll just get used to it, let's complete this whole Flash/LED
integration story.
--
Thanks,
Sylwester
next prev parent reply other threads:[~2015-04-08 14:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1427809965-25540-1-git-send-email-j.anaszewski@samsung.com>
2015-03-31 13:52 ` [PATCH v4 01/12] DT: leds: Improve description of flash LEDs related properties Jacek Anaszewski
2015-04-02 14:41 ` Pavel Machek
2015-04-03 12:09 ` Sakari Ailus
2015-04-03 12:56 ` Jacek Anaszewski
2015-04-03 20:37 ` Pavel Machek
2015-04-08 1:20 ` Bryan Wu
[not found] ` <CAK5ve-KR81cNrJnPj_XUkNvctsEYLDGb58qTVaOOAYJnoZTGXg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-04-08 7:48 ` Sakari Ailus
2015-04-08 9:13 ` Pavel Machek
2015-04-08 8:54 ` Jacek Anaszewski
2015-04-08 9:11 ` Sakari Ailus
2015-04-08 9:17 ` Pavel Machek
2015-04-08 10:23 ` Jacek Anaszewski
[not found] ` <5525019B.8050104-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-04-08 10:44 ` Sakari Ailus
2015-04-08 10:03 ` Sylwester Nawrocki
2015-04-08 10:36 ` Pavel Machek
2015-04-08 11:58 ` Jacek Anaszewski
2015-04-08 14:45 ` Sylwester Nawrocki [this message]
2015-03-31 13:52 ` [PATCH v4 04/12] DT: Add documentation for the mfd Maxim max77693 Jacek Anaszewski
[not found] ` <1427809965-25540-5-git-send-email-j.anaszewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-03-31 14:34 ` Jacek Anaszewski
2015-03-31 13:52 ` [PATCH v4 06/12] of: Add Skyworks Solutions, Inc. vendor prefix Jacek Anaszewski
2015-04-08 11:59 ` Sakari Ailus
2015-03-31 13:52 ` [PATCH v4 07/12] DT: Add documentation for the Skyworks AAT1290 Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55253F08.3040409@samsung.com \
--to=s.nawrocki@samsung.com \
--cc=cooloney@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=j.anaszewski@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-leds@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rpurdie@rpsys.net \
--cc=sakari.ailus@iki.fi \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).