From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 598DE37E30F; Thu, 30 Apr 2026 10:48:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546124; cv=none; b=QRPWytXthiBARCBrPSz49HcaRdjXfBWA/lQASXtQg2vI2P65MyLpABEbPHuH1/+3AAV6OW11Bu1CgEHBTeynLZd65sywkXc6yB16ccb7/dHau7wiP7iMx/OOTK0fy9oxi3SzEyzRkGWzPY/VRThkfIWmfLe2mC5i4O7GamH3xbw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777546124; c=relaxed/simple; bh=dc076GcKD+3U/9fyVv1BpskAGEG1i7yl9xbdLK3+ui4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Il18VQ4VWN2VQYkJUFrkXJim3ieBJfZ+Gnjy+rYZym6xL0uZqMM/SlFBKxFty2zbRTlYrhsi77At6x+ZuHkMr7PGqAOmR/TrkJF1oG61zNvQZIVmaRvprYnYBVusKfHlReyzPNhY+qgwb9scFMc1HWW/XfRGB4hoo83/kDRS8Dk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bhOE8ONC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bhOE8ONC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5FB4DC2BCB3; Thu, 30 Apr 2026 10:48:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1777546124; bh=dc076GcKD+3U/9fyVv1BpskAGEG1i7yl9xbdLK3+ui4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=bhOE8ONCopA3SzPX8cjzbA6/fnAzToaFtL9L0JOHgo/t2R64T5Oms9c/JlPOi9akP hQfxky/GXZ2psuSQtru4Oh828y3X4Bpmxx9vsbl7NY/JUd0lW5n0eAsdKWdMOiv0bv weG+cHTYed+TzwaRD98FyL50kpM1SyMvNsfp1MoG2VLLlWCOWu5BWqpChLBSoPMRQU yCncEwpKYuJTWo07+5vJWTYC8/5/iB/KvxYWu4BJtJGVKWerXqf+vhQywt6gmOu1mp V7FqoKuDEQ6CPZp1lJWD+l8C1kTZQb/hhFfy+ASsacJ14OpvhloTyjxZPkXdFjTmeo OR+Z9pxi2D5TA== Message-ID: <55258a51-9cdb-451c-be06-74b9b3020cbc@kernel.org> Date: Thu, 30 Apr 2026 12:48:35 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] dt-bindings: PCI: imx6q-pcie: Add intr, aer and pme interrupts To: Hongxing Zhu Cc: "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "bhelgaas@google.com" , Frank Li , "l.stach@pengutronix.de" , "lpieralisi@kernel.org" , "kwilczynski@kernel.org" , "mani@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "imx@lists.linux.dev" , "linux-kernel@vger.kernel.org" References: <20260430050954.3467984-1-hongxing.zhu@nxp.com> <20260430050954.3467984-2-hongxing.zhu@nxp.com> <20260430-proud-ammonite-of-gaiety-abaafc@quoll> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 30/04/2026 10:37, Hongxing Zhu wrote: >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Thursday, April 30, 2026 4:04 PM >> To: Hongxing Zhu >> Cc: robh@kernel.org; krzk+dt@kernel.org; conor+dt@kernel.org; >> bhelgaas@google.com; Frank Li ; l.stach@pengutronix.de; >> lpieralisi@kernel.org; kwilczynski@kernel.org; mani@kernel.org; >> s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com; linux- >> pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; >> devicetree@vger.kernel.org; imx@lists.linux.dev; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH v3 1/3] dt-bindings: PCI: imx6q-pcie: Add intr, aer and pme >> interrupts >> >> On Thu, Apr 30, 2026 at 01:09:52PM +0800, Richard Zhu wrote: >>> Add 'intr', 'aer', and 'pme' interrupt entries to the i.MX6Q PCIe >>> binding to support PCIe event-based interrupts for general controller >>> events, Advanced Error Reporting, and Power Management Events respectively. >>> >>> These interrupts are optional for existing variants (imx6q, imx6sx, >>> imx6qp, imx7d, imx8mq, imx8mm, imx8mp) to maintain backward >>> compatibility with existing device trees. >>> >>> For fsl,imx95-pcie, all 5 interrupts (msi, dma, intr, aer, pme) are >>> mandatory due to hardware requirements. >>> >>> This introduces an ABI requirement for fsl,imx95-pcie. The i.MX95 >>> hardware requires dedicated interrupt lines for AER, PME, and general >>> controller events due to its redesigned interrupt architecture. i.MX95 >>> cannot function correctly without explicit interrupt routing for error >>> handling, power management and link event detection. >> >> fsl,imx95-pcie was added more than two years ago, so how it cannot function >> correctly? Are you saying that for two years you had here completely broken >> code? >> >> If this wasn't tested for two years, how can we believe anything is tested now? > The basic PCIe functionality has been working since the initial fsl,imx95-pcie > support. However, AER (Advanced Error Reporting) and link up/down detection > were not previously enabled. This patch-set adds and verifies support for > these advanced features. > That is not what you said in the commit msg. Best regards, Krzysztof