From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v2 05/12] ARM: dts: apq8064: Add SATA controller support. Date: Fri, 10 Apr 2015 19:33:45 +0100 Message-ID: <55281789.2060402@linaro.org> References: <1428669187-10775-1-git-send-email-srinivas.kandagatla@linaro.org> <1428669263-10990-1-git-send-email-srinivas.kandagatla@linaro.org> <5528076B.1010808@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5528076B.1010808-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Boyd , galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/04/15 18:24, Stephen Boyd wrote: > On 04/10/15 05:34, Srinivas Kandagatla wrote: >> This patch adds AHCI based SATA controller support to APQ8064. >> Tested on IFC6410 board. >> >> Signed-off-by: Srinivas Kandagatla >> --- >> arch/arm/boot/dts/qcom-apq8064-ifc6410.dts | 9 ++++++++ >> arch/arm/boot/dts/qcom-apq8064.dtsi | 35 ++++++++++++++++++++++++++++++ >> 2 files changed, 44 insertions(+) >> >> diff --git a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> index 122bf34..c9c9c5e 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> +++ b/arch/arm/boot/dts/qcom-apq8064-ifc6410.dts >> @@ -116,6 +116,15 @@ >> }; >> }; >> >> + sata_phy0: sata-phy@1b400000{ > > Space before '{' please. Yeo, Will fix it in next version. > >> + status = "okay"; >> + }; >> + >> + sata0: sata@29000000 { >> + status = "okay"; >> + target-supply = <&pm8921_s4>; >> + }; >> + >> /* OTG */ >> usb1_phy: phy@12500000 { >> status = "okay"; >> diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi >> index 5aac9a5..56cc65e 100644 >> --- a/arch/arm/boot/dts/qcom-apq8064.dtsi >> +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi >> @@ -379,6 +379,41 @@ >> usb-phy = <&usb4_phy>; >> }; >> >> + sata_phy0: sata-phy@1b400000{ > > Space before '{' please. Also I wonder if it should just be called > phy@1b400000 because phy is more standard than sata-phy. Make sense, I will fix it in next version. > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html