From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, devicetree@vger.kernel.org,
galak@codeaurora.org, netdev@vger.kernel.org,
linux-sh@vger.kernel.org,
Mitsuhiro Kimura <mitsuhiro.kimura.kc@renesas.com>,
masaru.nagai.vx@renesas.com
Subject: Re: [PATCH resend] Renesas Ethernet AVB driver
Date: Tue, 14 Apr 2015 19:58:18 +0300 [thread overview]
Message-ID: <552D472A.6080309@cogentembedded.com> (raw)
In-Reply-To: <20150414163002.GB4309@localhost.localdomain>
Hello.
On 04/14/2015 07:30 PM, Richard Cochran wrote:
>>> It is surely avoidable. The driver knows (or should know) whether or
>>> not the hardware has been configured or not.
>> So you only want to avoid the register read here?
> No, that is not what I mean. The two callers are gettime and adjtime.
> Can't you make sure the hardware is ready before you register the
I tried to explain to you that I can't. We enter the device configuration
mode (from the operation mode) when e.g. the *Ethernet* device is closed.
> clock in the first place? If not, what is purpose of returning EBUSY?
I'm not sure (remember, I'm not the primary author), perhaps this is to
prevent bad time values when the AVB-DMAC in not operational... Nagai-san,
could you explain this please?
> Thanks,
> Richard
WBR, Sergei
next prev parent reply other threads:[~2015-04-14 16:58 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 23:13 [PATCH resend] Renesas Ethernet AVB driver Sergei Shtylyov
2015-03-28 5:17 ` Lino Sanfilippo
2015-03-28 8:36 ` Richard Cochran
2015-03-28 13:55 ` Sergei Shtylyov
2015-03-28 8:28 ` Richard Cochran
2015-03-28 18:26 ` David Miller
2015-03-30 22:51 ` Sergei Shtylyov
2015-03-31 6:43 ` Richard Cochran
2015-03-31 9:01 ` Richard Cochran
2015-03-31 15:38 ` David Miller
2015-03-31 17:40 ` Sergei Shtylyov
2015-03-31 17:48 ` David Miller
2015-04-03 6:27 ` masaru.nagai.vx
2015-04-12 22:03 ` Sergei Shtylyov
2015-04-09 13:11 ` Bjørn Mork
2015-04-09 17:57 ` David Miller
2015-04-13 20:23 ` Sergei Shtylyov
2015-04-14 5:27 ` Richard Cochran
2015-04-14 10:14 ` Sergei Shtylyov
2015-04-14 16:30 ` Richard Cochran
2015-04-14 16:58 ` Sergei Shtylyov [this message]
2015-04-14 18:30 ` Richard Cochran
2015-04-15 1:01 ` masaru.nagai.vx
2015-04-15 5:31 ` Richard Cochran
2015-04-02 13:56 ` Ben Hutchings
2015-04-13 20:34 ` Sergei Shtylyov
2015-04-13 22:13 ` Lino Sanfilippo
2015-04-13 22:31 ` Ben Hutchings
2015-04-13 22:53 ` Lino Sanfilippo
2015-04-13 23:08 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552D472A.6080309@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-sh@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masaru.nagai.vx@renesas.com \
--cc=mitsuhiro.kimura.kc@renesas.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).