From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH] [RFC] OF: probe order dependency aware of_platform_populate Date: Wed, 15 Apr 2015 10:17:45 -0400 Message-ID: <552E7309.8020505@hurleysoftware.com> References: <1418731891-24768-1-git-send-email-pantelis.antoniou@konsulko.com> <20150319191834.5346CC40A35@trevor.secretlab.ca> <8E250936-B06C-40B4-8C34-557D2361CAF6@konsulko.com> <1B3AF599-4A64-4FB0-BFB0-0C0544917C6C@konsulko.com> <20150402023803.E6A4DC4076D@trevor.secretlab.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Geert Uytterhoeven , Grant Likely , Pantelis Antoniou , Guenter Roeck , Greg Kroah-Hartman , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Matt Porter List-Id: devicetree@vger.kernel.org On 04/08/2015 09:40 AM, Rob Herring wrote: > This doesn't sound right. It ignores failures because platform_get_irq > will parse the interrupts when called rather than just using the > resource struct and will return EPROBE_DEFER if the irq resource is > not ready. We left the of_device_alloc code in to be safe, but we > should be able to remove it. This brings up a couple of points which are plaguing the serial drivers: 1. Is platform_get_irq() now required to properly obtain the mapped irq for DT-aware drivers? IOW, is platform_get_resource(IORESOURCE_IRQ) broken? Will it be if the of_device_alloc() code is removed? 2. Should DT-specific drivers not be using irq_of_parse_and_map()? On probe failure irq_dispose_mapping() will be junking the mapping, thus invalidating the irq assignment in the platform resource table, which breaks platform drivers which might otherwise probe successfully. Regards, Peter Hurley -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html