From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH 6/8] extcon: arizona: Add support for WM8998 and WM1814 Date: Wed, 22 Apr 2015 19:20:09 +0900 Message-ID: <553775D9.9080606@samsung.com> References: <1429619636-25478-1-git-send-email-rf@opensource.wolfsonmicro.com> <1429619636-25478-7-git-send-email-rf@opensource.wolfsonmicro.com> <55373766.6060106@samsung.com> <20150422091941.GA4303@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150422091941.GA4303@opensource.wolfsonmicro.com> Sender: linux-gpio-owner@vger.kernel.org To: Richard Fitzgerald Cc: lee.jones@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com, myungjoo.ham@samsung.com, ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 04/22/2015 06:19 PM, Richard Fitzgerald wrote: > On Wed, Apr 22, 2015 at 02:53:42PM +0900, Chanwoo Choi wrote: >> Hi Richard, >> >>> @@ -1176,6 +1182,11 @@ static int arizona_extcon_probe(struct platform_device *pdev) >>> break; >>> } >>> break; >>> + case WM8998: >>> + case WM1814: >>> + info->micd_clamp = true; >>> + info->hpdet_ip = 2; >> >> What is meaning of '2'? I prefer to use the definition for '2'. >> > > '2' is the version number of the hpdet ip block in silicon. We're already using > it as a raw number '0', '1' or '2' all over extcon-arizona.c so changing it here > would mean making other patches to the file that aren't really part of adding > WM8998 support, so I'd prefer not to change that as a side-effect of adding WM8998. I think that just you can define following definitions and use HPDET_IP_VER_V2 instead of '2'. #define HPDET_IP_VER_V0 0 #define HPDET_IP_VER_V1 1 #define HPDET_IP_VER_V2 2