From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH 7/9] ARM: Add Kconfig support for bcm2836. Date: Thu, 23 Apr 2015 21:30:03 -0600 Message-ID: <5539B8BB.3090905@wwwdotorg.org> References: <1429639796-2169-1-git-send-email-eric@anholt.net> <1429639796-2169-8-git-send-email-eric@anholt.net> <13864545.foFMzEn7Xk@wuerfel> <87lhhl9pzf.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <87lhhl9pzf.fsf-omZaPlIz5HhaEpDpdNBo/KxOck334EZe@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eric Anholt , Arnd Bergmann Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lee Jones , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On 04/21/2015 02:38 PM, Eric Anholt wrote: > Arnd Bergmann writes: >> On Tuesday 21 April 2015 11:09:54 Eric Anholt wrote: >>> @@ -116,17 +122,19 @@ config ARCH_BCM283X config ARCH_BCM2835 >>> bool "Broadcom BCM2835 family" if ARCH_MULTI_V6 select >>> ARCH_BCM283X - select ARCH_REQUIRE_GPIOLIB - select >>> ARM_AMBA select ARM_ERRATA_411920 select ARM_TIMER_SP804 - >>> select CLKSRC_OF - select PINCTRL - select >>> PINCTRL_BCM2835 help This enables support for the Broadcom >>> BCM2835 SoC. This SoC is used in the Raspberry Pi and Roku 2 >>> devices. >>> >>> +config ARCH_BCM2836 + bool "Broadcom BCM2836 family" if >>> ARCH_MULTI_V7 + select ARCH_BCM283X + help + >>> This enables support for the Broadcom BCM2836 SoC. This SoC is >>> + used in the Raspberry Pi 2 + >> >> The description for the first one says "Broadcom BCM2835 family", >> and I guess they are both in the same family. How about leaving >> the CONFIG_BCM2835 symbol to mean one of them, and just >> duplicating the DEBUG_LL symbols? >> >> You could do something like >> >> config ARCH_BCM2835 bool "Broadcom BCM2835 family" if >> ARCH_MULTI_V6 || ARCH_MULTI_V7 select ARCH_BCM283X select >> ARCH_REQUIRE_GPIOLIB select ARM_AMBA select ARM_ERRATA_411920 if >> ARCH_MULTI_V6 select ARM_TIMER_SP804 if ARCH_MULTI_V6 select >> CLKSRC_OF select PINCTRL select PINCTRL_BCM2835 help This enables >> support for the Broadcom BCM2835 and BCM2836 SoCs. These SoCs is >> used in the Raspberry Pi and Roku 2 devices. >> >> That should make it less confusing to the user, because they >> don't have to know which specific SoC they are building for, >> other than enabling the right architecture level. > > Seems reasonable to me. What do the 2835 maintainers think? Yes, sounds reasonable to me. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html