* ARCH_EXYNOS5433 missing in Kconfig
@ 2015-03-10 15:32 Valentin Rothberg
2015-03-11 1:10 ` Chanwoo Choi
0 siblings, 1 reply; 7+ messages in thread
From: Valentin Rothberg @ 2015-03-10 15:32 UTC (permalink / raw)
To: Sylwester Nawrocki, Tomasz Figa, Mike Turquette, Stephen Boyd,
Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell,
Kumar Gala, Chanwoo Choi, Inki Dae, linux-kernel,
linux-samsung-soc, linux-arm-kernel, devicetree, Andreas Ruprecht,
hengelein Stefan, Paul Bolle
Hi Chanwoo,
your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using
common clock framework") is included in today's linux-next tree (i.e.,
next-20150310).
This patch conditionally compiles clk-exynos5433.c depending on the
Kconfig option ARCH_EXYNOS5433. However, this option is not defined
in Kconfig, so that the driver cannot be compiled at the current
state:
+obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o
Is there a patch queued somewhere that adds this Kconfig symbol? I
detected the issue by running undertaker-checkpatch from the
Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in
the git tree that can detect such issues (i.e.,
scripts/checkkconfigsymbols.py).
Kind regards,
Valentin
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: ARCH_EXYNOS5433 missing in Kconfig 2015-03-10 15:32 ARCH_EXYNOS5433 missing in Kconfig Valentin Rothberg @ 2015-03-11 1:10 ` Chanwoo Choi 2015-03-11 8:21 ` Valentin Rothberg 2015-04-27 6:31 ` Valentin Rothberg 0 siblings, 2 replies; 7+ messages in thread From: Chanwoo Choi @ 2015-03-11 1:10 UTC (permalink / raw) To: Valentin Rothberg Cc: Sylwester Nawrocki, Tomasz Figa, Mike Turquette, Stephen Boyd, Kukjin Kim, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Inki Dae, linux-kernel, linux-samsung-soc, linux-arm-kernel, devicetree, Andreas Ruprecht, hengelein Stefan, Paul Bolle, Arnd Bergmann Hi Valentin, I sent the Exynos5433 clock patch and then separately I'm sending the Exynos5433 devicetree patch-set[1]. [1] [PATCH v6 0/9] arm64: Add the support for new Exynos5433 SoC - https://lkml.org/lkml/2015/3/9/1036 But, according to Arnd bergmann's comment[2], latest Exynos5433 dt patch-set[1] removed the CONFIG_ARCH_EXYNOS5433. [2] https://lkml.org/lkml/2015/2/24/85 So, I have plan to send following patch. --- clk: samsung: Use CONFIG_ARCH_EXYNOS instead of Exynos-specific configuration This patch removes the CONFIG_ARCH_EXYNOS{5433|7} and then use only the CONFIG_ARCH_EXYNOS for ARM-64bit Exynos SoC. Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> Cc: Tomasz Figa <tomasz.figa@gmail.com> Cc: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> --- drivers/clk/samsung/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile index 17e9af7..561719d 100644 --- a/drivers/clk/samsung/Makefile +++ b/drivers/clk/samsung/Makefile @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o -obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o +obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o Regards, Chanwoo Choi On 03/11/2015 12:32 AM, Valentin Rothberg wrote: > Hi Chanwoo, > > your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using > common clock framework") is included in today's linux-next tree (i.e., > next-20150310). > > This patch conditionally compiles clk-exynos5433.c depending on the > Kconfig option ARCH_EXYNOS5433. However, this option is not defined > in Kconfig, so that the driver cannot be compiled at the current > state: > > +obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o > > Is there a patch queued somewhere that adds this Kconfig symbol? I > detected the issue by running undertaker-checkpatch from the > Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in > the git tree that can detect such issues (i.e., > scripts/checkkconfigsymbols.py). > > Kind regards, > Valentin > ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: ARCH_EXYNOS5433 missing in Kconfig 2015-03-11 1:10 ` Chanwoo Choi @ 2015-03-11 8:21 ` Valentin Rothberg 2015-04-27 6:31 ` Valentin Rothberg 1 sibling, 0 replies; 7+ messages in thread From: Valentin Rothberg @ 2015-03-11 8:21 UTC (permalink / raw) To: Chanwoo Choi Cc: Sylwester Nawrocki, Tomasz Figa, Mike Turquette, Stephen Boyd, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Inki Dae, linux-kernel, linux-samsung-soc, linux-arm-kernel, devicetree, Andreas Ruprecht, hengelein Stefan, Paul Bolle, Arnd Bergmann, 김국진@kernel.org On Wed, Mar 11, 2015 at 2:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi Valentin, > > I sent the Exynos5433 clock patch and then separately I'm sending the > Exynos5433 devicetree patch-set[1]. > [1] [PATCH v6 0/9] arm64: Add the support for new Exynos5433 SoC > - https://lkml.org/lkml/2015/3/9/1036 > > But, according to Arnd bergmann's comment[2], latest Exynos5433 dt patch-set[1] > removed the CONFIG_ARCH_EXYNOS5433. > [2] https://lkml.org/lkml/2015/2/24/85 > > > So, I have plan to send following patch. Great! Thanks for your reply and the explanation. Kind regards, Valentin > --- > clk: samsung: Use CONFIG_ARCH_EXYNOS instead of Exynos-specific configuration > > This patch removes the CONFIG_ARCH_EXYNOS{5433|7} and then use only the > CONFIG_ARCH_EXYNOS for ARM-64bit Exynos SoC. > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/clk/samsung/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile > index 17e9af7..561719d 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o > obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o > obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o > obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o > -obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o > +obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o > obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o > > > Regards, > Chanwoo Choi > > > On 03/11/2015 12:32 AM, Valentin Rothberg wrote: >> Hi Chanwoo, >> >> your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using >> common clock framework") is included in today's linux-next tree (i.e., >> next-20150310). >> >> This patch conditionally compiles clk-exynos5433.c depending on the >> Kconfig option ARCH_EXYNOS5433. However, this option is not defined >> in Kconfig, so that the driver cannot be compiled at the current >> state: >> >> +obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o >> >> Is there a patch queued somewhere that adds this Kconfig symbol? I >> detected the issue by running undertaker-checkpatch from the >> Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in >> the git tree that can detect such issues (i.e., >> scripts/checkkconfigsymbols.py). >> >> Kind regards, >> Valentin >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ARCH_EXYNOS5433 missing in Kconfig 2015-03-11 1:10 ` Chanwoo Choi 2015-03-11 8:21 ` Valentin Rothberg @ 2015-04-27 6:31 ` Valentin Rothberg 2015-04-28 9:25 ` Chanwoo Choi 1 sibling, 1 reply; 7+ messages in thread From: Valentin Rothberg @ 2015-04-27 6:31 UTC (permalink / raw) To: Chanwoo Choi Cc: Sylwester Nawrocki, Tomasz Figa, Mike Turquette, Stephen Boyd, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Inki Dae, linux-kernel, linux-samsung-soc, linux-arm-kernel, devicetree, Andreas Ruprecht, hengelein Stefan, Paul Bolle, Arnd Bergmann, 김국진@kernel.org Hi Chanwoo, this is a kind reminder that the issue mentioned below is still present and made its way to v4.1-rc1. Kind regards, Valentin On Wed, Mar 11, 2015 at 2:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: > Hi Valentin, > > I sent the Exynos5433 clock patch and then separately I'm sending the > Exynos5433 devicetree patch-set[1]. > [1] [PATCH v6 0/9] arm64: Add the support for new Exynos5433 SoC > - https://lkml.org/lkml/2015/3/9/1036 > > But, according to Arnd bergmann's comment[2], latest Exynos5433 dt patch-set[1] > removed the CONFIG_ARCH_EXYNOS5433. > [2] https://lkml.org/lkml/2015/2/24/85 > > > So, I have plan to send following patch. > > --- > clk: samsung: Use CONFIG_ARCH_EXYNOS instead of Exynos-specific configuration > > This patch removes the CONFIG_ARCH_EXYNOS{5433|7} and then use only the > CONFIG_ARCH_EXYNOS for ARM-64bit Exynos SoC. > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> > Cc: Tomasz Figa <tomasz.figa@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> > --- > drivers/clk/samsung/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile > index 17e9af7..561719d 100644 > --- a/drivers/clk/samsung/Makefile > +++ b/drivers/clk/samsung/Makefile > @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o > obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o > obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o > obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o > -obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o > +obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o > obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o > obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o > > > Regards, > Chanwoo Choi > > > On 03/11/2015 12:32 AM, Valentin Rothberg wrote: >> Hi Chanwoo, >> >> your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using >> common clock framework") is included in today's linux-next tree (i.e., >> next-20150310). >> >> This patch conditionally compiles clk-exynos5433.c depending on the >> Kconfig option ARCH_EXYNOS5433. However, this option is not defined >> in Kconfig, so that the driver cannot be compiled at the current >> state: >> >> +obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o >> >> Is there a patch queued somewhere that adds this Kconfig symbol? I >> detected the issue by running undertaker-checkpatch from the >> Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in >> the git tree that can detect such issues (i.e., >> scripts/checkkconfigsymbols.py). >> >> Kind regards, >> Valentin >> > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ARCH_EXYNOS5433 missing in Kconfig 2015-04-27 6:31 ` Valentin Rothberg @ 2015-04-28 9:25 ` Chanwoo Choi 2015-04-28 9:58 ` Sylwester Nawrocki 0 siblings, 1 reply; 7+ messages in thread From: Chanwoo Choi @ 2015-04-28 9:25 UTC (permalink / raw) To: Valentin Rothberg, Sylwester Nawrocki Cc: Tomasz Figa, Mike Turquette, Stephen Boyd, Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala, Inki Dae, linux-kernel, linux-samsung-soc, linux-arm-kernel, devicetree, Andreas Ruprecht, hengelein Stefan, Paul Bolle, Arnd Bergmann, 김국진@kernel.org Hi Valentin, On Mon, Apr 27, 2015 at 3:31 PM, Valentin Rothberg <valentinrothberg@gmail.com> wrote: > Hi Chanwoo, > > this is a kind reminder that the issue mentioned below is still > present and made its way to v4.1-rc1. I sent the patch[1] to fix it. And Sylwester said that he will pick this patchset on patch[2]. [1] https://lkml.org/lkml/2015/4/27/237 [2] https://lkml.org/lkml/2015/4/28/117 Hi Sylwester, Could you apply a patch[1] on 4.2-rc2 to fix build warning? Best Regards, Chanwoo Choi > > Kind regards, > Valentin > > On Wed, Mar 11, 2015 at 2:10 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote: >> Hi Valentin, >> >> I sent the Exynos5433 clock patch and then separately I'm sending the >> Exynos5433 devicetree patch-set[1]. >> [1] [PATCH v6 0/9] arm64: Add the support for new Exynos5433 SoC >> - https://lkml.org/lkml/2015/3/9/1036 >> >> But, according to Arnd bergmann's comment[2], latest Exynos5433 dt patch-set[1] >> removed the CONFIG_ARCH_EXYNOS5433. >> [2] https://lkml.org/lkml/2015/2/24/85 >> >> >> So, I have plan to send following patch. >> >> --- >> clk: samsung: Use CONFIG_ARCH_EXYNOS instead of Exynos-specific configuration >> >> This patch removes the CONFIG_ARCH_EXYNOS{5433|7} and then use only the >> CONFIG_ARCH_EXYNOS for ARM-64bit Exynos SoC. >> >> Cc: Sylwester Nawrocki <s.nawrocki@samsung.com> >> Cc: Tomasz Figa <tomasz.figa@gmail.com> >> Cc: Arnd Bergmann <arnd@arndb.de> >> Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com> >> --- >> drivers/clk/samsung/Makefile | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/samsung/Makefile b/drivers/clk/samsung/Makefile >> index 17e9af7..561719d 100644 >> --- a/drivers/clk/samsung/Makefile >> +++ b/drivers/clk/samsung/Makefile >> @@ -10,11 +10,11 @@ obj-$(CONFIG_SOC_EXYNOS5250) += clk-exynos5250.o >> obj-$(CONFIG_SOC_EXYNOS5260) += clk-exynos5260.o >> obj-$(CONFIG_SOC_EXYNOS5410) += clk-exynos5410.o >> obj-$(CONFIG_SOC_EXYNOS5420) += clk-exynos5420.o >> -obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o >> +obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos5433.o >> obj-$(CONFIG_SOC_EXYNOS5440) += clk-exynos5440.o >> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-audss.o >> obj-$(CONFIG_ARCH_EXYNOS) += clk-exynos-clkout.o >> >> >> Regards, >> Chanwoo Choi >> >> >> On 03/11/2015 12:32 AM, Valentin Rothberg wrote: >>> Hi Chanwoo, >>> >>> your commit 96bd6224f07b ("clk: samsung: exynos5433: Add clocks using >>> common clock framework") is included in today's linux-next tree (i.e., >>> next-20150310). >>> >>> This patch conditionally compiles clk-exynos5433.c depending on the >>> Kconfig option ARCH_EXYNOS5433. However, this option is not defined >>> in Kconfig, so that the driver cannot be compiled at the current >>> state: >>> >>> +obj-$(CONFIG_ARCH_EXYNOS5433) += clk-exynos5433.o >>> >>> Is there a patch queued somewhere that adds this Kconfig symbol? I >>> detected the issue by running undertaker-checkpatch from the >>> Undertaker tool suite (undertaker.cs.fau.de). There is also a tool in >>> the git tree that can detect such issues (i.e., >>> scripts/checkkconfigsymbols.py). >>> >>> Kind regards, >>> Valentin >>> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ARCH_EXYNOS5433 missing in Kconfig 2015-04-28 9:25 ` Chanwoo Choi @ 2015-04-28 9:58 ` Sylwester Nawrocki 2015-04-28 10:21 ` Chanwoo Choi 0 siblings, 1 reply; 7+ messages in thread From: Sylwester Nawrocki @ 2015-04-28 9:58 UTC (permalink / raw) To: cw00.choi Cc: Valentin Rothberg, Tomasz Figa, Mike Turquette, Stephen Boyd, Inki Dae, linux-kernel, linux-samsung-soc, linux-arm-kernel, devicetree, Paul Bolle Hello, On 28/04/15 11:25, Chanwoo Choi wrote: > Hi Valentin, > > On Mon, Apr 27, 2015 at 3:31 PM, Valentin Rothberg > <valentinrothberg@gmail.com> wrote: >> > Hi Chanwoo, >> > >> > this is a kind reminder that the issue mentioned below is still >> > present and made its way to v4.1-rc1. > > I sent the patch[1] to fix it. And Sylwester said that he will pick > this patchset on patch[2]. > [1] https://lkml.org/lkml/2015/4/27/237 > [2] https://lkml.org/lkml/2015/4/28/117 > > Hi Sylwester, > Could you apply a patch[1] on 4.2-rc2 to fix build warning? Sure, I plan to send a pull request this week. -- Regards, Sylwester ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: ARCH_EXYNOS5433 missing in Kconfig 2015-04-28 9:58 ` Sylwester Nawrocki @ 2015-04-28 10:21 ` Chanwoo Choi 0 siblings, 0 replies; 7+ messages in thread From: Chanwoo Choi @ 2015-04-28 10:21 UTC (permalink / raw) To: Sylwester Nawrocki Cc: Valentin Rothberg, Tomasz Figa, Mike Turquette, Stephen Boyd, Inki Dae, linux-kernel, linux-samsung-soc, linux-arm-kernel, devicetree, Paul Bolle Hi Sylwester, On Tue, Apr 28, 2015 at 6:58 PM, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote: > Hello, > > On 28/04/15 11:25, Chanwoo Choi wrote: >> Hi Valentin, >> >> On Mon, Apr 27, 2015 at 3:31 PM, Valentin Rothberg >> <valentinrothberg@gmail.com> wrote: >>> > Hi Chanwoo, >>> > >>> > this is a kind reminder that the issue mentioned below is still >>> > present and made its way to v4.1-rc1. >> >> I sent the patch[1] to fix it. And Sylwester said that he will pick >> this patchset on patch[2]. >> [1] https://lkml.org/lkml/2015/4/27/237 >> [2] https://lkml.org/lkml/2015/4/28/117 >> >> Hi Sylwester, >> Could you apply a patch[1] on 4.2-rc2 to fix build warning? > > Sure, I plan to send a pull request this week. OK. Thanks. Best Regards, Chanwoo Choi ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-04-28 10:21 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-10 15:32 ARCH_EXYNOS5433 missing in Kconfig Valentin Rothberg 2015-03-11 1:10 ` Chanwoo Choi 2015-03-11 8:21 ` Valentin Rothberg 2015-04-27 6:31 ` Valentin Rothberg 2015-04-28 9:25 ` Chanwoo Choi 2015-04-28 9:58 ` Sylwester Nawrocki 2015-04-28 10:21 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).