[PATCH v2 1/2] soc: qcom: Add device tree binding for SMEM

[PATCH v2 1/2] soc: qcom: Add device tree binding for SMEM

[Bjorn Andersson]

Add device tree binding documentation for the Qualcom Shared Memory
manager.

Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
---

Changes since v1:
- None

 .../devicetree/bindings/soc/qcom/qcom,smem.txt     | 49 ++++++++++++++++++++++
 1 file changed, 49 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt

diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
new file mode 100644
index 0000000..d90f839
--- /dev/null
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
@@ -0,0 +1,49 @@
+Qualcomm Shared Memory binding
+
+This binding describes the Qualcomm Shared Memory, used to share data between
+various subsystems and OSes in Qualcomm platforms.
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be:
+		    "qcom,smem"
+
+- memory-region:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: handle to memory reservation for main smem memory region.
+
+- reg:
+	Usage: optional
+	Value type: <prop-encoded-array>
+	Definition: base address and size pair for any additional memory areas
+		    of the shared memory.
+
+- hwspinlocks:
+	Usage: required
+	Value type: <prop-encoded-array>
+	Definition: reference to a hwspinlock used to protect allocations from
+		    the shared memory
+
+= EXAMPLE
+
+	reserved-memory {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		ranges;
+
+		smem_region: smem@fa00000 {
+			reg = <0xfa00000 0x200000>;
+			no-map;
+		};
+	};
+
+	smem@fa00000 {
+		compatible = "qcom,smem";
+
+		memory-region = <&smem_region>;
+		reg = <0xfc428000 0x4000>;
+
+		hwlocks = <&tcsr_mutex 3>;
+	};
-- 
1.8.2.2

Re: [PATCH v2 1/2] soc: qcom: Add device tree binding for SMEM

[Jeffrey Hugo]

On 4/11/2015 5:32 PM, Bjorn Andersson wrote:
> Add device tree binding documentation for the Qualcom Shared Memory
> manager.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
>
> Changes since v1:
> - None
>
>   .../devicetree/bindings/soc/qcom/qcom,smem.txt     | 49 ++++++++++++++++++++++
>   1 file changed, 49 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> new file mode 100644
> index 0000000..d90f839
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> @@ -0,0 +1,49 @@
> +Qualcomm Shared Memory binding
> +
> +This binding describes the Qualcomm Shared Memory, used to share data between
> +various subsystems and OSes in Qualcomm platforms.
> +
> +- compatible:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be:
> +		    "qcom,smem"
> +
> +- memory-region:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: handle to memory reservation for main smem memory region.
> +
> +- reg:
> +	Usage: optional
> +	Value type: <prop-encoded-array>
> +	Definition: base address and size pair for any additional memory areas
> +		    of the shared memory.
> +
> +- hwspinlocks:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: reference to a hwspinlock used to protect allocations from
> +		    the shared memory
> +
> += EXAMPLE
> +
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		smem_region: smem@fa00000 {
> +			reg = <0xfa00000 0x200000>;
> +			no-map;
> +		};
> +	};
> +
> +	smem@fa00000 {
> +		compatible = "qcom,smem";
> +
> +		memory-region = <&smem_region>;
> +		reg = <0xfc428000 0x4000>;
> +
> +		hwlocks = <&tcsr_mutex 3>;
> +	};
>

For my information, is there any intention to support the relocatable 
smem_region by looking it up at init time?  It does not seem like it 
would be possible to support that with this binding.

-- 
Jeffrey Hugo
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project

Re: [PATCH v2 1/2] soc: qcom: Add device tree binding for SMEM

[Bjorn Andersson]

On Thu, Apr 23, 2015 at 1:01 PM, Jeffrey Hugo <jhugo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
> On 4/11/2015 5:32 PM, Bjorn Andersson wrote:
>>
>> Add device tree binding documentation for the Qualcom Shared Memory
>> manager.
>>
[..]
>
> For my information, is there any intention to support the relocatable
> smem_region by looking it up at init time?  It does not seem like it would
> be possible to support that with this binding.
>

I haven't been able to grasp the purpose of making the smem addresses
completely dynamic. As far as I can see there might be use cases where
certain devices needs to move the smem region from the default area.
But even so, it's not dynamically choosen so it's in essence static -
so we can just encode it in the individual dts files.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] soc: qcom: Add device tree binding for SMEM

[Andy Gross]

On Thu, Apr 23, 2015 at 02:01:28PM -0600, Jeffrey Hugo wrote:
> On 4/11/2015 5:32 PM, Bjorn Andersson wrote:
> >Add device tree binding documentation for the Qualcom Shared Memory
> >manager.
> >
> >Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> >---
> >
> >Changes since v1:
> >- None
> >
> >  .../devicetree/bindings/soc/qcom/qcom,smem.txt     | 49 ++++++++++++++++++++++
> >  1 file changed, 49 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> >
> >diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> >new file mode 100644
> >index 0000000..d90f839
> >--- /dev/null
> >+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> >@@ -0,0 +1,49 @@
> >+Qualcomm Shared Memory binding
> >+
> >+This binding describes the Qualcomm Shared Memory, used to share data between
> >+various subsystems and OSes in Qualcomm platforms.
> >+
> >+- compatible:
> >+	Usage: required
> >+	Value type: <stringlist>
> >+	Definition: must be:
> >+		    "qcom,smem"
> >+
> >+- memory-region:
> >+	Usage: required
> >+	Value type: <prop-encoded-array>
> >+	Definition: handle to memory reservation for main smem memory region.
> >+
> >+- reg:
> >+	Usage: optional
> >+	Value type: <prop-encoded-array>
> >+	Definition: base address and size pair for any additional memory areas
> >+		    of the shared memory.
> >+
> >+- hwspinlocks:
> >+	Usage: required
> >+	Value type: <prop-encoded-array>
> >+	Definition: reference to a hwspinlock used to protect allocations from
> >+		    the shared memory
> >+
> >+= EXAMPLE
> >+
> >+	reserved-memory {
> >+		#address-cells = <1>;
> >+		#size-cells = <1>;
> >+		ranges;
> >+
> >+		smem_region: smem@fa00000 {
> >+			reg = <0xfa00000 0x200000>;
> >+			no-map;
> >+		};
> >+	};
> >+
> >+	smem@fa00000 {
> >+		compatible = "qcom,smem";
> >+
> >+		memory-region = <&smem_region>;
> >+		reg = <0xfc428000 0x4000>;
> >+
> >+		hwlocks = <&tcsr_mutex 3>;
> >+	};
> >
> 
> For my information, is there any intention to support the
> relocatable smem_region by looking it up at init time?  It does not
> seem like it would be possible to support that with this binding.

The APPS processor really doesn't need anything except the memory region in the
DT.  If it was truly going to be dynamic, we could modify the DT in the
bootloader to set the correct address.  We can let the other processors get the
information through the WONCE TCSR registers.

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

Re: [PATCH v2 1/2] soc: qcom: Add device tree binding for SMEM

[Jeffrey Hugo]

On 4/11/2015 5:32 PM, Bjorn Andersson wrote:
> Add device tree binding documentation for the Qualcom Shared Memory
> manager.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
> ---
>
> Changes since v1:
> - None
>
>   .../devicetree/bindings/soc/qcom/qcom,smem.txt     | 49 ++++++++++++++++++++++
>   1 file changed, 49 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> new file mode 100644
> index 0000000..d90f839
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smem.txt
> @@ -0,0 +1,49 @@
> +Qualcomm Shared Memory binding
> +
> +This binding describes the Qualcomm Shared Memory, used to share data between
> +various subsystems and OSes in Qualcomm platforms.
> +
> +- compatible:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be:
> +		    "qcom,smem"
> +
> +- memory-region:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: handle to memory reservation for main smem memory region.
> +
> +- reg:
> +	Usage: optional
> +	Value type: <prop-encoded-array>
> +	Definition: base address and size pair for any additional memory areas
> +		    of the shared memory.
> +
> +- hwspinlocks:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: reference to a hwspinlock used to protect allocations from
> +		    the shared memory
> +
> += EXAMPLE
> +
> +	reserved-memory {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges;
> +
> +		smem_region: smem@fa00000 {
> +			reg = <0xfa00000 0x200000>;
> +			no-map;
> +		};
> +	};
> +
> +	smem@fa00000 {
> +		compatible = "qcom,smem";
> +
> +		memory-region = <&smem_region>;
> +		reg = <0xfc428000 0x4000>;
> +
> +		hwlocks = <&tcsr_mutex 3>;

Just noticed, this looks like a typo.  The description of the field 
above calls it "hwspinlocks".  Would to please determine which of the 
two labels you most prefer, and change things so that label is used in 
both the description and the example?  Thanks

> +	};
>


-- 
Jeffrey Hugo
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora 
Forum, a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 1/2] soc: qcom: Add device tree binding for SMEM

[Bjorn Andersson]

On Thu, Apr 30, 2015 at 8:38 AM, Jeffrey Hugo <jhugo@codeaurora.org> wrote:
> On 4/11/2015 5:32 PM, Bjorn Andersson wrote:
>>
>> Add device tree binding documentation for the Qualcom Shared Memory
>> manager.
[..]
>> +- hwspinlocks:
>> +       Usage: required
>> +       Value type: <prop-encoded-array>
>> +       Definition: reference to a hwspinlock used to protect allocations
>> from
>> +                   the shared memory
>> +
>> += EXAMPLE
[..]
>> +               hwlocks = <&tcsr_mutex 3>;
>
>
> Just noticed, this looks like a typo.  The description of the field above
> calls it "hwspinlocks".  Would to please determine which of the two labels
> you most prefer, and change things so that label is used in both the
> description and the example?  Thanks
>

Thanks, you're correct it's a typo in the definition.

Regards,
Bjorn