From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH v2 2/5] phy: qcom: Add Qualcomm PCIe PHY Date: Mon, 4 May 2015 20:05:57 +0530 Message-ID: <554783CD.50708@ti.com> References: <1430743338-10441-1-git-send-email-svarbanov@mm-sol.com> <1430743338-10441-3-git-send-email-svarbanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1430743338-10441-3-git-send-email-svarbanov@mm-sol.com> Sender: linux-arm-msm-owner@vger.kernel.org To: Stanimir Varbanov , Rob Herring , Kumar Gala , Mark Rutland , Grant Likely , Bjorn Helgaas , Russell King , Arnd Bergmann Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-pci@vger.kernel.org, Mathieu Olivari , Srinivas Kandagatla List-Id: devicetree@vger.kernel.org Hi, On Monday 04 May 2015 06:12 PM, Stanimir Varbanov wrote: > Add a PCIe PHY driver used by PCIe host controller driver > on Qualcomm SoCs like Snapdragon 805. > > Signed-off-by: Stanimir Varbanov > --- > drivers/phy/Kconfig | 9 ++ > drivers/phy/Makefile | 1 + > drivers/phy/phy-qcom-pcie.c | 291 +++++++++++++++++++++++++++++++++++++++++++ Why do you need a new PHY driver for this? Why not use the existing QCOM PHY driver. I can see the registers used here in phy-qcom-ufs-qmp-14nm.h? Thanks Kishon