From: Peter Hurley <peter@hurleysoftware.com>
To: Rob Herring <robherring2@gmail.com>, Eyal Reizer <eyalreizer@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap <linux-omap@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Eliad Peller <eliad@wizery.com>, Eyal Reizer <eyalr@ti.com>
Subject: Re: [PATCH 2/2] am335x-evm: add bluetooth support
Date: Mon, 04 May 2015 19:38:34 -0400 [thread overview]
Message-ID: <554802FA.6050700@hurleysoftware.com> (raw)
In-Reply-To: <CAL_JsqJd=6nG1S-Mds+MiS4wSmKnOUo2nBnA6wjGSycXECLpcQ@mail.gmail.com>
Hi Rob,
On 05/04/2015 06:28 PM, Rob Herring wrote:
> On Sun, May 3, 2015 at 7:19 AM, Eyal Reizer <eyalreizer@gmail.com> wrote:
>> From: Eliad Peller <eliad@wizery.com>
>>
>> uart1 is used for shared transport (used for multiplexing
>> bluetooth and nfc data). add the needed muxes and definitions.
>>
>> Signed-off-by: Eliad Peller <eliad@wizery.com>
>> Signed-off-by: Eyal Reizer <eyalr@ti.com>
>> ---
>> arch/arm/boot/dts/am335x-evm.dts | 28 ++++++++++++++++++++++++++++
>> 1 file changed, 28 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am335x-evm.dts b/arch/arm/boot/dts/am335x-evm.dts
>> index 0f398fa..5968cde 100644
>> --- a/arch/arm/boot/dts/am335x-evm.dts
>> +++ b/arch/arm/boot/dts/am335x-evm.dts
>> @@ -135,6 +135,18 @@
>> };
>> };
>>
>> + kim {
>> + compatible = "kim";
>
> Who is kim?
drivers/misc/ti-st/st_kim.c, et.al.
>> + nshutdown_gpio = <117>; /* Bank3, pin21 */
>
> We have a standard way to specify gpios.
>
>> + dev_name = "/dev/ttyS1";
>
> Uh, Linux specific. No.
>
>> + flow_cntrl = <1>;
>> + baud_rate = <3000000>;
>
> I believe there are standard properties for uarts for both of these.
>
> Is any of this documented?
See commit 46d0d333 ("ti-st: add device tree support").
Don't shoot the messenger; I had nothing to do with this.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-05-04 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-03 12:19 [PATCH 1/2] am335x-evm: add mmc3 and wlan definitions to dts Eyal Reizer
[not found] ` <1430655569-27849-1-git-send-email-eyalr-l0cyMroinI0@public.gmane.org>
2015-05-03 12:19 ` [PATCH 2/2] am335x-evm: add bluetooth support Eyal Reizer
2015-05-04 22:28 ` Rob Herring
2015-05-04 23:38 ` Peter Hurley [this message]
2015-05-05 6:06 ` Reizer, Eyal
2015-05-21 19:08 ` [PATCH 1/2] am335x-evm: add mmc3 and wlan definitions to dts Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554802FA.6050700@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=devicetree@vger.kernel.org \
--cc=eliad@wizery.com \
--cc=eyalr@ti.com \
--cc=eyalreizer@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=robherring2@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).