From: Arnd Bergmann <arnd@arndb.de>
To: Andy Gross <agross@codeaurora.org>
Cc: linux-arm-kernel@lists.infradead.org,
Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver
Date: Tue, 21 Jan 2014 09:03:43 +0100 [thread overview]
Message-ID: <5548936.L46nLkuVIz@wuerfel> (raw)
In-Reply-To: <20140120225245.GA3530@qualcomm.com>
On Monday 20 January 2014 16:52:45 Andy Gross wrote:
> > > +#ifdef CONFIG_OF
> > > +static const struct of_device_id bam_of_match[] = {
> > > + { .compatible = "qcom,bam-v1.4.0", },
> > > + { .compatible = "qcom,bam-v1.4.1", },
> > > + {}
> > > +};
> > > +MODULE_DEVICE_TABLE(of, bam_of_match);
> > > +#endif
> >
> > Also, you can remove the #ifdef here and the of_match_ptr() below.
> >
>
> If this is removed, then I'll have to add the OF dependency in the Kconfig,
> correct?
I believe it will still compile without the CONFIG_OF dependency, but
having the dependency still makes sense as it's impossible to use the
driver without CONFIG_OF.
The best dependency line is probably
depends on (ARCH_MSM && OF) || COMPILE_TEST"
If you expect the same driver to be used on non-MSM platforms from
qualcomm, e.g. some networking or server equipment, you can also just
drop the ARCH_MSM dependency.
Arnd
next prev parent reply other threads:[~2014-01-21 8:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 19:07 [PATCH v2 0/2] Add Qualcomm BAM dmaengine driver Andy Gross
2014-01-10 19:07 ` [PATCH v2 1/2] dmaengine: add Qualcomm BAM dma driver Andy Gross
2014-01-13 10:31 ` Shevchenko, Andriy
2014-01-20 23:31 ` Andy Gross
2014-01-14 19:43 ` Stephen Boyd
2014-01-20 23:20 ` Andy Gross
2014-01-17 22:49 ` Arnd Bergmann
2014-01-20 22:52 ` Andy Gross
2014-01-21 8:03 ` Arnd Bergmann [this message]
2014-01-21 23:01 ` Andy Gross
2014-01-21 23:12 ` Arnd Bergmann
2014-01-23 20:17 ` Kumar Gala
2014-01-23 22:50 ` Andy Gross
2014-01-10 19:07 ` [PATCH v2 2/2] dmaengine: qcom_bam_dma: Add device tree binding Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548936.L46nLkuVIz@wuerfel \
--to=arnd@arndb.de \
--cc=agross@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox