From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aidan MacDonald <aidanmacdonald.0x0@gmail.com>,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] ASoC: Add ESS ES9218P codec driver
Date: Thu, 11 May 2023 11:53:09 +0200 [thread overview]
Message-ID: <55489ae6-dddc-ca72-07ea-761bf1e40912@linaro.org> (raw)
In-Reply-To: <20230510112349.939991-1-aidanmacdonald.0x0@gmail.com>
On 10/05/2023 13:23, Aidan MacDonald wrote:
> The ES9218P is a 32-bit stereo codec featuring an integrated
> headphone amp with analog volume control and up to 2.0 V rms
> output, and a low-power bypass path for passing through an
> analog signal from an alternate source.
>
> The digital audio interface supports 16/24/32-bit I2S inputs
> ranging from 8 KHz to 384 KHz, and DSD inputs. This driver
> only supports I2S operation.
...
> +static const struct of_device_id es9218p_of_match[] = {
> + { .compatible = "ess,es9218p" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, es9218p_of_match);
> +
> +static const struct i2c_device_id es9218p_i2c_id[] = {
> + { "ess-es9218p", 0 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, es9218p_i2c_id);
> +
> +static struct i2c_driver es9218p_i2c_driver = {
> + .driver = {
> + .name = "ess-es9218p",
> + .of_match_table = of_match_ptr(es9218p_of_match),
Drop of_match_ptr or add __maybe_unused to the table.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-11 9:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-10 11:23 [PATCH v1 1/3] ASoC: Add ESS ES9218P codec driver Aidan MacDonald
2023-05-10 11:23 ` [PATCH v1 2/3] dt-bindings: vendor-prefixes: Add ESS Technology vendor prefix Aidan MacDonald
2023-05-11 9:53 ` Krzysztof Kozlowski
2023-05-10 11:23 ` [PATCH v1 3/3] dt-bindings: ASoC: Add ESS ES9218P codec bindings Aidan MacDonald
2023-05-11 9:58 ` Krzysztof Kozlowski
2023-05-11 10:15 ` Aidan MacDonald
2023-05-11 11:10 ` Krzysztof Kozlowski
2023-05-11 11:26 ` Aidan MacDonald
2023-05-11 17:57 ` Krzysztof Kozlowski
2023-05-11 9:53 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55489ae6-dddc-ca72-07ea-761bf1e40912@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aidanmacdonald.0x0@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox