* [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese keys
@ 2015-05-05 2:07 Chris Zhong
2015-05-05 18:10 ` Doug Anderson
0 siblings, 1 reply; 4+ messages in thread
From: Chris Zhong @ 2015-05-05 2:07 UTC (permalink / raw)
To: dianders, dtor, sonnyrao
Cc: linux-rockchip, Chris Zhong, Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
linux-arm-kernel, linux-kernel
Add support for 4 Japanese keys
Signed-off-by: Chris Zhong <zyw@rock-chips.com>
---
arch/arm/boot/dts/cros-ec-keyboard.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
index 9c7fb0a..4e42f30c 100644
--- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
+++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
@@ -22,6 +22,7 @@
MATRIX_KEY(0x00, 0x02, KEY_F1)
MATRIX_KEY(0x00, 0x03, KEY_B)
MATRIX_KEY(0x00, 0x04, KEY_F10)
+ MATRIX_KEY(0x00, 0x05, KEY_RO)
MATRIX_KEY(0x00, 0x06, KEY_N)
MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
@@ -34,6 +35,7 @@
MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
MATRIX_KEY(0x01, 0x09, KEY_F9)
MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
+ MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
MATRIX_KEY(0x02, 0x01, KEY_TAB)
@@ -45,6 +47,7 @@
MATRIX_KEY(0x02, 0x07, KEY_102ND)
MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
MATRIX_KEY(0x02, 0x09, KEY_F8)
+ MATRIX_KEY(0x02, 0x0a, KEY_YEN)
MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
MATRIX_KEY(0x03, 0x02, KEY_F2)
@@ -53,6 +56,7 @@
MATRIX_KEY(0x03, 0x06, KEY_6)
MATRIX_KEY(0x03, 0x08, KEY_MINUS)
MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
+ MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
MATRIX_KEY(0x04, 0x01, KEY_A)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese keys
2015-05-05 2:07 [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese keys Chris Zhong
@ 2015-05-05 18:10 ` Doug Anderson
2015-05-06 0:59 ` Chris Zhong
2015-07-13 21:47 ` Olof Johansson
0 siblings, 2 replies; 4+ messages in thread
From: Doug Anderson @ 2015-05-05 18:10 UTC (permalink / raw)
To: Chris Zhong, Olof Johansson
Cc: Dmitry Torokhov, Sonny Rao, open list:ARM/Rockchip SoC...,
Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Chris,
On Mon, May 4, 2015 at 7:07 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> Add support for 4 Japanese keys
>
> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>
> ---
>
> arch/arm/boot/dts/cros-ec-keyboard.dtsi | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> index 9c7fb0a..4e42f30c 100644
> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
> @@ -22,6 +22,7 @@
> MATRIX_KEY(0x00, 0x02, KEY_F1)
> MATRIX_KEY(0x00, 0x03, KEY_B)
> MATRIX_KEY(0x00, 0x04, KEY_F10)
> + MATRIX_KEY(0x00, 0x05, KEY_RO)
> MATRIX_KEY(0x00, 0x06, KEY_N)
> MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
> MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
> @@ -34,6 +35,7 @@
> MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
> MATRIX_KEY(0x01, 0x09, KEY_F9)
> MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
> + MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
>
> MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
> MATRIX_KEY(0x02, 0x01, KEY_TAB)
> @@ -45,6 +47,7 @@
> MATRIX_KEY(0x02, 0x07, KEY_102ND)
> MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
> MATRIX_KEY(0x02, 0x09, KEY_F8)
> + MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>
> MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
> MATRIX_KEY(0x03, 0x02, KEY_F2)
> @@ -53,6 +56,7 @@
> MATRIX_KEY(0x03, 0x06, KEY_6)
> MATRIX_KEY(0x03, 0x08, KEY_MINUS)
> MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
> + MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
>
> MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
> MATRIX_KEY(0x04, 0x01, KEY_A)
Since there's no clear architecture here, I'd bet Olof would be the
one to take this. I added him to this email, but he might request
that you resend the patch with him in the "To:" line.
Other than that:
Reviewed-by: Doug Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese keys
2015-05-05 18:10 ` Doug Anderson
@ 2015-05-06 0:59 ` Chris Zhong
2015-07-13 21:47 ` Olof Johansson
1 sibling, 0 replies; 4+ messages in thread
From: Chris Zhong @ 2015-05-06 0:59 UTC (permalink / raw)
To: Doug Anderson, Olof Johansson
Cc: Dmitry Torokhov, Sonny Rao, open list:ARM/Rockchip SoC...,
Rob Herring, Pawel Moll, Mark Rutland, Ian Campbell, Kumar Gala,
Russell King, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On 05/06/2015 02:10 AM, Doug Anderson wrote:
> Chris,
>
> On Mon, May 4, 2015 at 7:07 PM, Chris Zhong <zyw@rock-chips.com> wrote:
>> Add support for 4 Japanese keys
>>
>> Signed-off-by: Chris Zhong <zyw@rock-chips.com>
>>
>> ---
>>
>> arch/arm/boot/dts/cros-ec-keyboard.dtsi | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/cros-ec-keyboard.dtsi b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> index 9c7fb0a..4e42f30c 100644
>> --- a/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> +++ b/arch/arm/boot/dts/cros-ec-keyboard.dtsi
>> @@ -22,6 +22,7 @@
>> MATRIX_KEY(0x00, 0x02, KEY_F1)
>> MATRIX_KEY(0x00, 0x03, KEY_B)
>> MATRIX_KEY(0x00, 0x04, KEY_F10)
>> + MATRIX_KEY(0x00, 0x05, KEY_RO)
>> MATRIX_KEY(0x00, 0x06, KEY_N)
>> MATRIX_KEY(0x00, 0x08, KEY_EQUAL)
>> MATRIX_KEY(0x00, 0x0a, KEY_RIGHTALT)
>> @@ -34,6 +35,7 @@
>> MATRIX_KEY(0x01, 0x08, KEY_APOSTROPHE)
>> MATRIX_KEY(0x01, 0x09, KEY_F9)
>> MATRIX_KEY(0x01, 0x0b, KEY_BACKSPACE)
>> + MATRIX_KEY(0x01, 0x0c, KEY_HENKAN)
>>
>> MATRIX_KEY(0x02, 0x00, KEY_LEFTCTRL)
>> MATRIX_KEY(0x02, 0x01, KEY_TAB)
>> @@ -45,6 +47,7 @@
>> MATRIX_KEY(0x02, 0x07, KEY_102ND)
>> MATRIX_KEY(0x02, 0x08, KEY_LEFTBRACE)
>> MATRIX_KEY(0x02, 0x09, KEY_F8)
>> + MATRIX_KEY(0x02, 0x0a, KEY_YEN)
>>
>> MATRIX_KEY(0x03, 0x01, KEY_GRAVE)
>> MATRIX_KEY(0x03, 0x02, KEY_F2)
>> @@ -53,6 +56,7 @@
>> MATRIX_KEY(0x03, 0x06, KEY_6)
>> MATRIX_KEY(0x03, 0x08, KEY_MINUS)
>> MATRIX_KEY(0x03, 0x0b, KEY_BACKSLASH)
>> + MATRIX_KEY(0x03, 0x0c, KEY_MUHENKAN)
>>
>> MATRIX_KEY(0x04, 0x00, KEY_RIGHTCTRL)
>> MATRIX_KEY(0x04, 0x01, KEY_A)
> Since there's no clear architecture here, I'd bet Olof would be the
> one to take this. I added him to this email, but he might request
> that you resend the patch with him in the "To:" line.
>
> Other than that:
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
>
Thank you, I'll resend the patch with Olof.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese keys
2015-05-05 18:10 ` Doug Anderson
2015-05-06 0:59 ` Chris Zhong
@ 2015-07-13 21:47 ` Olof Johansson
1 sibling, 0 replies; 4+ messages in thread
From: Olof Johansson @ 2015-07-13 21:47 UTC (permalink / raw)
To: Doug Anderson
Cc: Chris Zhong, Dmitry Torokhov, Sonny Rao,
open list:ARM/Rockchip SoC..., Rob Herring, Pawel Moll,
Mark Rutland, Ian Campbell, Kumar Gala, Russell King,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
On Tue, May 05, 2015 at 11:10:42AM -0700, Doug Anderson wrote:
> Chris,
>
> Since there's no clear architecture here, I'd bet Olof would be the
> one to take this. I added him to this email, but he might request
> that you resend the patch with him in the "To:" line.
>
> Other than that:
>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Very belatedly applied for 4.2 fixes.
-Olof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-13 21:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-05 2:07 [PATCH] ARM: dts: cros-ec-keyboard: Add support for some Japanese keys Chris Zhong
2015-05-05 18:10 ` Doug Anderson
2015-05-06 0:59 ` Chris Zhong
2015-07-13 21:47 ` Olof Johansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).