Re: [PATCH v8 1/5] arm64: Enable EDAC on ARM64

[Jon Masters <jcm@redhat.com>]

Hi Loc,

Great to see v8 of the patches :) A comment below.

On 05/06/2015 12:02 AM, Loc Ho wrote:

> Add an stub atomic_scrub function and enable EDAC for arm64.

> +/*
> + * ECC atomic, DMA, SMP and interrupt safe scrub function.
> + */

nit: I expect you'll still get a little push back on that (similar to
last time) because it doesn't actually implement anything, so while it
is "safe" it's only because it's empty :) Might be better to indicate
that those are the features it is supposed to have when implemented.

> +static inline void atomic_scrub(void *va, u32 size)
> +{
> +	/* Stub function for now until an ARM64 HW has a way to test it. */
> +	WARN_ONCE(1, "not implemented");
> +}

That's great and seems to address the previous comment from v7.

Thanks,

Jon.