From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi. Date: Wed, 6 May 2015 09:45:15 +0200 Message-ID: <5549C68B.9090602@xilinx.com> References: <1430817426-5241-1-git-send-email-stripathi@apm.com> <4635229.bceBxngCoe@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4635229.bceBxngCoe@wuerfel> Sender: linux-mmc-owner@vger.kernel.org To: Arnd Bergmann , Suman Tripathi Cc: Rob Herring , "chris@printf.net" , Anton Vorontsov , Michal Simek , "linux-mmc@vger.kernel.org" , linuxppc-dev , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Don Dutile , "jcm@redhat.com" , Mark Langsdorf , "patches@apm.com" List-Id: devicetree@vger.kernel.org On 05/06/2015 09:31 AM, Arnd Bergmann wrote: > On Wednesday 06 May 2015 10:41:07 Suman Tripathi wrote: >>>> @@ -533,6 +567,16 @@ >>>> interrupts = <0x0 0x4f 0x4>; >>>> }; >>>> >>>> + sdhc0: sdhc@1c000000 { >>>> + device_type = "sdhc"; >>> >>> device_type generally should not be used (there are a few exceptions). >> >> Okay !! >> > > While we're at it, please change sdhc@1c000000 to mmc@1c000000. > Even though Linux does not care, we try to use the standard device > names for consistency. Do we have a list of these names somewhere? Normally I do use ePARP - generic names recommendation but mmc or sdhci are not listed there. Both combination mmc@ or sdhci@ are used in the kernel. On zynq and zynqmp we do use shdci@. Thanks, Michal