From: Heiko Stuebner <heiko@sntech.de>
To: Guodong Xu <guodong.xu@linaro.org>
Cc: shawn.lin@rock-chips.com, jh80.chung@samsung.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
ulf.hansson@linaro.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
Zhangfei Gao <zhangfei.gao@linaro.org>
Subject: Re: [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc
Date: Fri, 01 Apr 2016 20:42:40 +0200 [thread overview]
Message-ID: <5552254.5pm4SI4ary@phil> (raw)
In-Reply-To: <1459322696-29919-3-git-send-email-guodong.xu@linaro.org>
Am Mittwoch, 30. März 2016, 15:24:56 schrieb Guodong Xu:
[...]
> @@ -2949,7 +2956,9 @@ int dw_mci_probe(struct dw_mci *host)
>
> if (!host->pdata) {
> host->pdata = dw_mci_parse_dt(host);
> - if (IS_ERR(host->pdata)) {
> + if (PTR_ERR(host->pdata) == -EPROBE_DEFER) {
> + return -EPROBE_DEFER;
> + } else if (IS_ERR(host->pdata)) {
how is this related to adding the reset handling?
Making the driver handle probe deferral better should be a separate patch.
> dev_err(host->dev, "platform data not available\n");
> return -EINVAL;
> }
> @@ -3012,6 +3021,9 @@ int dw_mci_probe(struct dw_mci *host)
> }
> }
>
> + if (!IS_ERR(host->pdata->rstc))
> + reset_control_deassert(host->pdata->rstc);
> +
Wouldn't reset_control_reset be better? The way it is now it would expect
the reset to be asserted somewhere else before dw_mmc probes?
> setup_timer(&host->cmd11_timer,
> dw_mci_cmd11_timer, (unsigned long)host);
>
[...]
> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
> index 7b41c6d..b95cd84 100644
> --- a/include/linux/mmc/dw_mmc.h
> +++ b/include/linux/mmc/dw_mmc.h
> @@ -14,9 +14,10 @@
> #ifndef LINUX_MMC_DW_MMC_H
> #define LINUX_MMC_DW_MMC_H
>
> -#include <linux/scatterlist.h>
> -#include <linux/mmc/core.h>
> #include <linux/dmaengine.h>
> +#include <linux/mmc/core.h>
> +#include <linux/reset.h>
> +#include <linux/scatterlist.h>
unrelated changed regarding the reordering of includes.
Heiko
next prev parent reply other threads:[~2016-04-01 18:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 7:24 [PATCH v3 0/2] mmc: dw_mmc: controller reset support Guodong Xu
2016-03-30 7:24 ` [PATCH v3 1/2] Documentation: synopsys-dw-mshc: add binding for resets Guodong Xu
2016-03-30 7:24 ` [PATCH v3 2/2] mmc: dw_mmc: add resets support to dw_mmc Guodong Xu
2016-03-30 11:40 ` Jaehoon Chung
2016-04-01 18:42 ` Heiko Stuebner
2016-04-02 12:11 ` Guodong Xu
2016-04-04 3:54 ` Jaehoon Chung
2016-04-01 18:42 ` Heiko Stuebner [this message]
2016-04-02 13:39 ` Guodong Xu
2016-04-02 14:03 ` Heiko Stuebner
2016-05-25 13:33 ` Guodong Xu
[not found] ` <1459322696-29919-1-git-send-email-guodong.xu-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-30 11:45 ` [PATCH v3 0/2] mmc: dw_mmc: controller reset support Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5552254.5pm4SI4ary@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=guodong.xu@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jh80.chung@samsung.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
--cc=zhangfei.gao@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).