From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: Re: [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node tothe Odroid-XU3 board Date: Wed, 13 May 2015 17:17:42 +0900 Message-ID: <555308A6.308@kernel.org> References: <1431499020-3912-1-git-send-email-linux.amoon@gmail.com> <1431499020-3912-2-git-send-email-linux.amoon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: Anand Moon , Eduardo Valentin , Lukasz Majewski , linux-samsung-soc@vger.kernel.org, Russell King , devicetree@vger.kernel.org, Markus Reichl , Sjoerd Simons , Kukjin Kim , linux-arm-kernel@lists.infradead.org, Guenter Roeck List-Id: devicetree@vger.kernel.org On 05/13/15 16:11, Krzysztof Kozlowski wrote: > 2015-05-13 15:36 GMT+09:00 Anand Moon : >> Add pwm-fan node to the Odroid-XU3 board. >> >> Tested-by: Markus Reichl >> Acked-by: Lukasz Majewski >> Signed-off-by: Anand Moon > > Please fix the title of commit (missing colon, duplicated name of board) to: > "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node" > Well, I'd preferred to use the following format: "ARM: dts: add pwm-fan node for exynos5422-odroidxu3" But I can change it when I apply it ;-) > Rest looks good: > Acked-by: Krzysztof Kozlowski > Thanks, Kukjin