From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Kuske Subject: Re: [PATCH v2 07/10] pinctrl: sunxi: Add H3 PIO controller support Date: Mon, 18 May 2015 11:52:29 +0200 Message-ID: <5559B65D.8020108@gmail.com> References: <1431707940-19372-1-git-send-email-jenskuske@gmail.com> <1431707940-19372-8-git-send-email-jenskuske@gmail.com> <20150517143014.GH4004@lukather> Reply-To: jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20150517143014.GH4004@lukather> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Maxime Ripard Cc: =?windows-1252?Q?Emilio_L=F3pez?= , Mike Turquette , Linus Walleij , Rob Herring , Chen-Yu Tsai , Vishnu Patekar , Hans de Goede , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 05/17/15 16:30, Maxime Ripard wrote: > On Fri, May 15, 2015 at 06:38:57PM +0200, Jens Kuske wrote: >> The H3 uses the same pin controller as previous SoC's from Allwinner. >> Add support for the pins controlled by the main PIO controller. >> >> Signed-off-by: Jens Kuske >> --- >> .../bindings/pinctrl/allwinner,sunxi-pinctrl.txt | 1 + >> drivers/pinctrl/sunxi/Kconfig | 8 + >> drivers/pinctrl/sunxi/Makefile | 1 + >> drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c | 522 +++++++++++++++++++++ >> 4 files changed, 532 insertions(+) >> create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-h3.c >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt >> index fdd8046..c46af8e 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt >> +++ b/Documentation/devicetree/bindings/pinctrl/allwinner,sunxi-pinctrl.txt >> @@ -16,6 +16,7 @@ Required properties: >> "allwinner,sun7i-a20-pinctrl" >> "allwinner,sun8i-a23-pinctrl" >> "allwinner,sun8i-a23-r-pinctrl" >> + "allwinner,sun8i-h3-pinctrl" >> - reg: Should contain the register physical address and length for the >> pin controller. >> >> diff --git a/drivers/pinctrl/sunxi/Kconfig b/drivers/pinctrl/sunxi/Kconfig >> index 2eb893e..6c1cec5 100644 >> --- a/drivers/pinctrl/sunxi/Kconfig >> +++ b/drivers/pinctrl/sunxi/Kconfig >> @@ -43,6 +43,14 @@ config PINCTRL_SUN8I_A23_R >> depends on RESET_CONTROLLER >> select PINCTRL_SUNXI_COMMON >> >> +config PINCTRL_SUN8I_H3 >> + tristate "Allwinner H3 pinctrl driver" >> + default MACH_SUN8I >> + select PINCTRL_SUNXI_COMMON > > PINCTRL_SUNXI_COMMON should probably be turned into a tristate as well Probably, as well as all the other SoC specific drivers. But I think this should be a separate patch, its independent from this addition. But given the remove-panic problems I mentioned earlier this whole pinctrl-as-module topic needs some attention from more experienced devs I guess, this is beyond my current kernel knowledge. Regards, Jens