devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Corentin LABBE <clabbe.montjoie@gmail.com>
To: herbert@gondor.apana.org.au,
	Boris Brezillon <boris.brezillon@free-electrons.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	maxime.ripard@free-electrons.com, linux@arm.linux.org.uk,
	davem@davemloft.net, akpm@linux-foundation.org,
	gregkh@linuxfoundation.org, mchehab@osg.samsung.com,
	joe@perches.com, tj@kernel.org, arnd@arndb.de,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator
Date: Sun, 24 May 2015 10:04:16 +0200	[thread overview]
Message-ID: <55618600.6040904@gmail.com> (raw)
In-Reply-To: <20150524033253.GB20656@gondor.apana.org.au>

Le 24/05/2015 05:32, Herbert Xu a écrit :
> On Sat, May 23, 2015 at 04:35:36PM +0200, Boris Brezillon wrote:
>>
>>> Since all SG I get was always a multiple of 16 (AES BLOCK SIZE) it was a sort of confirmation.
>>>
>>> Herbert ? does am I right or a chunking test is missing for cbc(aes) in testmgr.h
>>
>> Okay, just sharing my vision of this thing (I'll let Herbert comment on
>> this aspect): I'd say that theoretically nothing prevents one from
>> splitting its sg list in chunks smaller than the block size, so I'd
>> say you should use the same trick for AES. 
> 
> Indeed, you must be able to handle a block that straddles two SG
> entries.  If the hardware is not capable then you have to linearise
> it by copying or use a fallback.
> 
> I can't believe we don't have a generic test for this in testmgr.
> 

For aes_cbc it exists a test with 3 SG with .tap = { 496 - 20, 4, 16 }
But my driver handle that. (multiple of 4)

What do you think about adding a test with 16 SG of 1 byte ? (or 3 + 2 + 3 + 8 * 1)

Furthermore, I need to re-read testmgr.h but it seems that no aes test exists with odd SG size.


  reply	other threads:[~2015-05-24  8:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-14 12:58 [PATCH v9] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2015-05-14 12:58 ` [PATCH v9 2/4] ARM: sun4i: dt: Add DT bindings documentation for SUN4I Security System LABBE Corentin
     [not found] ` <1431608341-10936-1-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-14 12:58   ` [PATCH v9 1/4] ARM: sun7i: dt: Add Security System to A20 SoC DTS LABBE Corentin
2015-05-15  7:31     ` Maxime Ripard
2015-05-23 12:08       ` Corentin LABBE
2015-05-14 12:59   ` [PATCH v9 3/4] MAINTAINERS: Add myself as maintainer of Allwinner Security System LABBE Corentin
2015-05-14 12:59   ` [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
     [not found]     ` <1431608341-10936-5-git-send-email-clabbe.montjoie-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-15  6:49       ` Herbert Xu
     [not found]         ` <20150515064932.GB16704-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-23 12:18           ` Corentin LABBE
2015-05-24  3:30             ` [linux-sunxi] " Herbert Xu
2015-05-17  8:45       ` Boris Brezillon
2015-05-17 10:34         ` Herbert Xu
     [not found]           ` <20150517103440.GA7800-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-17 10:48             ` Boris Brezillon
2015-05-18  0:41               ` Herbert Xu
     [not found]                 ` <20150518004121.GA11910-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-18  7:24                   ` Boris Brezillon
2015-05-18  8:33                     ` Herbert Xu
2015-05-23 13:12         ` Corentin LABBE
     [not found]           ` <55607CB7.8020505-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-23 14:35             ` Boris Brezillon
2015-05-24  3:32               ` Herbert Xu
2015-05-24  8:04                 ` Corentin LABBE [this message]
     [not found]                   ` <55618600.6040904-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-05-24  8:12                     ` Herbert Xu
2015-06-03 19:06               ` Corentin LABBE
2015-05-15  6:52     ` Herbert Xu
     [not found]       ` <20150515065222.GA16808-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org>
2015-05-16 18:09         ` Corentin LABBE
2015-05-17  1:32           ` [linux-sunxi] " Herbert Xu
2015-05-17  7:45   ` [PATCH v9] " Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55618600.6040904@gmail.com \
    --to=clabbe.montjoie@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=boris.brezillon@free-electrons.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=joe@perches.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=mchehab@osg.samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).