From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2 6/7] Watchdog: introduce ARM SBSA watchdog driver Date: Sun, 24 May 2015 10:32:31 -0700 Message-ID: <55620B2F.5000708@roeck-us.net> References: <=fu.wei@linaro.org> <1432197156-16947-1-git-send-email-fu.wei@linaro.org> <1432197156-16947-7-git-send-email-fu.wei@linaro.org> <555DFCD4.3040701@codeaurora.org> <5560D7AC.50009@codeaurora.org> <5560DCB6.3090008@roeck-us.net> <5561E7EA.5090702@codeaurora.org> <5561F8A8.4080607@codeaurora.org> <5561FC70.5080802@roeck-us.net> <5561FFF0.5090108@codeaurora.org> <55620808.4030605@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <55620808.4030605-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> Sender: linux-watchdog-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Timur Tabi , Fu Wei Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Ashwin Chaugule , Arnd Bergmann , vgandhi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, wim-IQzOog9fTRqzQB+pC5nmwQ@public.gmane.org, Jon Masters , Leo Duran , Jon Corbet , Mark Rutland List-Id: devicetree@vger.kernel.org On 05/24/2015 10:19 AM, Timur Tabi wrote: > Fu Wei wrote: >> I don't know why you want to do this tricky way. you can always >> register the interrupt handler, >> if pre-timeout is 0, system will just trigger WS1 right after WS0 > > But that only works if the pre-timeout and timeout can be programmed to separate values. And as Guenter says, the SBSA may not guarantee that. > The pseudo-code in the specification suggests that if WCV is configured, WS0 = WCV WS1 = WCV + WOR Assuming that the implementation follows the pseudo-code in the specification, we would have separately programmable values. Since the pretimeout (per ABI) is the difference in seconds to the timeout, and not an absolute value, we would have to program the registers as follows. WCV = timeout - pretimeout; WOR = pretimeout; Does this make sense ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html