From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabrice Gasnier <fabrice.gasnier@st.com>
Subject: Re: [RFC PATCH v1 1/3] PCI: designware: Add ARM64 support
Date: Mon, 25 May 2015 17:51:55 +0200
Message-ID: <5563451B.4050609@st.com>
References: <000001d096a9$27bf43f0$773dcbd0$@com> <5562F0C9.4090007@hisilicon.com> <000001d096f1$93dca4e0$bb95eea0$@com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-pci-owner@vger.kernel.org>
In-Reply-To: <000001d096f1$93dca4e0$bb95eea0$@com>
Sender: linux-pci-owner@vger.kernel.org
To: 'Zhou Wang' <wangzhou1@hisilicon.com>
Cc: Jingoo Han <jingoohan1@gmail.com>, zhudacai@hisilicon.com, devicetree@vger.kernel.org, 'Gabriele Paoloni' <gabriele.paoloni@huawei.com>, 'Arnd Bergmann' <arnd@arndb.de>, 'Richard Zhu' <Richard.Zhu@freescale.com>, linux-pci@vger.kernel.org, 'Pratyush Anand' <pratyush.anand@gmail.com>, 'Liviu Dudau' <liviu.dudau@arm.com>, 'Zhichang Yuan' <yuanzhichang@hisilicon.com>, 'Kishon Vijay Abraham I' <kishon@ti.com>, qiuzhenfa@hisilicon.com, 'Bjorn Helgaas' <bhelgaas@google.com>, 'Zhang Jukuo' <zhangjukuo@huawei.com>, 'Liguozhu' <liguozhu@hisilicon.com>, linux-arm-kernel@lists.infradead.org, 'Lucas Stach' <l.stach@pengutronix.de>
List-Id: devicetree@vger.kernel.org

Hi Zhou,

On 05/25/2015 03:48 PM, Jingoo Han wrote:
>> >so how about we set 0 as default value of pp->root_bus_nr, then use
>> >pci_create_root_bus(pp->dev, pp->root_bus_nr, &dw_pcie_ops, pp, &res);
>> >to create root bus?
> I agree with your opinion. However, I still want to wait for other
> people's opinions. They will give good comments.
> Thank you.
>
> Best regards,
> Jingoo Han
>
I did a quick test with your patch in the context of another driver on 
arm32.
Just to confirm I added as well pp->root_bus_nr = 0;

Then, I needed to add dummy pci_sys_data as suggested by Arnd in the 
first review :
http://www.spinics.net/lists/linux-pci/msg40445.html

  struct pcie_port {
+#ifdef CONFIG_ARM
+	/*
+	 * this is a temporary hack to let the driver work on
+	 * both arm32 and arm64. it can be removed after the
+	 * arm32 cleanup is complete and bios32.c has stopped
+	 * referencing host->pci_sys_data.
+	 */
+	struct pci_sys_data	dummy;
+#endif
  	struct device		*dev;


This looks like necessary as bios32 is dereferencing sysdata:
struct pci_sys_data *sysdata = dev->bus->sysdata;

Best Regards,
Fabrice