From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH 08/15] of_serial: support for UARTs on I/O ports Date: Tue, 26 May 2015 09:53:55 -0400 Message-ID: <55647AF3.1000508@hurleysoftware.com> References: <1432309875-9712-1-git-send-email-paul.burton@imgtec.com> <1432309875-9712-9-git-send-email-paul.burton@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1432309875-9712-9-git-send-email-paul.burton-1AXoQHu6uovQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Paul Burton , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, Arnd Bergmann Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Greg Kroah-Hartman , Jiri Slaby , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org [ + Arnd who has been reviewing/acking of_serial.c changes ] On 05/22/2015 11:51 AM, Paul Burton wrote: > If the address provided for the UART is of an I/O port rather than > a regular memory address, then set the port iotype appropriately and > write the address to iobase rather than mapbase. > > Signed-off-by: Paul Burton > --- > > drivers/tty/serial/of_serial.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/of_serial.c b/drivers/tty/serial/of_serial.c > index 137381e..ccff9ba 100644 > --- a/drivers/tty/serial/of_serial.c > +++ b/drivers/tty/serial/of_serial.c > @@ -110,7 +110,12 @@ static int of_platform_serial_setup(struct platform_device *ofdev, > > port->irq = irq_of_parse_and_map(np, 0); > port->iotype = UPIO_MEM; > - if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > + > + if (resource.flags & IORESOURCE_IO) { > + port->iotype = UPIO_PORT; > + port->iobase = port->mapbase; > + port->mapbase = 0; > + } else if (of_property_read_u32(np, "reg-io-width", &prop) == 0) { > switch (prop) { > case 1: > port->iotype = UPIO_MEM; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html