From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v2 06/13] musb: Add support for the Allwinner sunxi musb controller Date: Tue, 26 May 2015 18:36:30 +0200 Message-ID: <5564A10E.3040402@redhat.com> References: <1426878682-14521-1-git-send-email-hdegoede@redhat.com> <1426878682-14521-7-git-send-email-hdegoede@redhat.com> <20150526154802.GL26599@saruman.tx.rr.com> Reply-To: hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Return-path: In-Reply-To: <20150526154802.GL26599-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: balbi-l0cyMroinI0@public.gmane.org Cc: Kishon Vijay Abraham I , Maxime Ripard , Chen-Yu Tsai , Roman Byshko , linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Arnd Bergmann List-Id: devicetree@vger.kernel.org Hi, On 05/26/2015 05:48 PM, Felipe Balbi wrote: > On Fri, Mar 20, 2015 at 08:11:15PM +0100, Hans de Goede wrote: >> This is based on initial code to get the Allwinner sunxi musb controller >> supported by Chen-Yu Tsai and Roman Byshko. >> >> This adds support for the Allwinner sunxi musb controller in both host only >> and otg mode. Peripheral only mode is not supported, as no boards use that. >> >> This has been tested on a cubietruck (A20 SoC) and an UTOO P66 tablet >> (A13 SoC) with a variety of devices in host mode and with the g_serial gadget >> driver in peripheral mode, plugging otg / host cables in/out a lot of times >> in all possible imaginable plug orders. >> >> Signed-off-by: Hans de Goede > > drivers/usb/musb/sunxi.c:28:11: error: unable to open 'linux/soc/sunxi/sunxi_sram.h' > scripts/Makefile.build:264: recipe for target 'drivers/usb/musb/sunxi.o' failed > make[2]: *** [drivers/usb/musb/sunxi.o] Error 1 > make[2]: *** Waiting for unfinished jobs.... > scripts/Makefile.build:403: recipe for target 'drivers/usb/musb' failed > make[1]: *** [drivers/usb/musb] Error 2 > Makefile:1548: recipe for target 'drivers/usb/' failed > make: *** [drivers/usb/] Error 2 > > What is the dependency ? Thanks you that you're working on this, the dependency is the sunxi sram controller driver which was supposed to get pulled for 4.1, but like many other ARM related pull-reqs did not get pulled. And now for 4.2 Arnd has decided that he does not like the driver even though it was ok for 4.1, and has not yet answered how else we should solve this... Arnd, we would really like to move forward with musb support for sunxi which means we need a solution for the sram controller, can you please answer Maxime's latest mails on this, or accept the driver as is ? Regards, Hans