From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH v2 3/6] ARM: dts: sun8i: Add sun8i-a23-a33 dtsi Date: Tue, 02 Jun 2015 10:08:39 +0200 Message-ID: <556D6487.4010207@redhat.com> References: <1432997706-20172-1-git-send-email-hdegoede@redhat.com> <1432997706-20172-4-git-send-email-hdegoede@redhat.com> <20150602075120.GL23777@lukather> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150602075120.GL23777@lukather> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maxime Ripard Cc: Chen-Yu Tsai , Vishnu Patekar , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree , linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi, On 02-06-15 09:51, Maxime Ripard wrote: > On Sat, May 30, 2015 at 04:55:03PM +0200, Hans de Goede wrote: >> From: Vishnu Patekar >> >> Rename sun8i-a23.dtsi to sun8i-a23-a33.dtsi as the base dtsi for the A33 >> is 99% the same and add a new sun8i-a23.dtsi including sun8i-a23-a33.dtsi >> and setting the few things not shared with the A33 (mbus-clk, pio >> compatible and interrupts). >> >> Signed-off-by: Vishnu Patekar >> Signed-off-by: Hans de Goede > > Fixed the conflicts and applied. > > Also judging from a quick look at the datasheet, the A33 doesn't seem > to have that clock gates tree but rather one similar to the H3's. That > will probably mean we'll have to move out the gates from this DTSI at > some point. Heuh... Ok so I've done a full bit for bit comparison of the 2 datasheets for the clk gates, mostly they are mostly the same and the registers seem to just be renamed. The only differences are: 01c200060 (AHB1 MODULE CLOCK GATING REGISTER 0 / Bus Clock Gating Register 0): Only A33 has bit 5 SS gating 01c200064 (AHB1 MODULE CLOCK GATING REGISTER 1 / Bus Clock Gating Register 1): Only A33 has bit 26 SAT gating, note that if we add support for this we must add it as a needed clock to the simplefb node Only A33 has bit 21 MSGBOX_GATING 01c200068 (APB1 MODULE CLOCK GATING REGISTER / Bus Clock Gating Register 2): No differences 01c20006c (APB2 MODULE CLOCK GATING REGISTER / Bus Clock Gating Register 3): No differences So you are right that in the near future we should add a separate compatible + clk driver or the ahb1_gates on the A33, but it does not seem that there is the issue of one gate register having multiple parents like on the H3. Or maybe the H3 does also not have that issue, and this is a misinterpretation of the H3 datasheet ? Note I do not know what the actual parent clock for the new gates is, but it stands to reason that it is AHB1, I've been unable to find anything to confirm or deny this. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html