From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Lee Jones <lee.jones@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Simon Glass <sjg@google.com>,
Gwendal Grignou <gwendal@google.com>,
Stephen Barber <smbarber@chromium.org>,
Filipe Brandenburger <filbranden@google.com>,
Todd Broch <tbroch@chromium.org>,
Alexandru M Stan <amstan@chromium.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system
Date: Fri, 05 Jun 2015 12:40:33 +0200 [thread overview]
Message-ID: <55717CA1.8060503@collabora.co.uk> (raw)
In-Reply-To: <20150605103810.GF7058@x1>
Hello Lee,
On 06/05/2015 12:38 PM, Lee Jones wrote:
[...]
>>
>> - err = mfd_add_devices(dev, 0, cros_devs,
>> - ARRAY_SIZE(cros_devs),
>> + err = mfd_add_devices(ec_dev->dev, PLATFORM_DEVID_AUTO, &ec_cell, 1,
>> NULL, ec_dev->irq, NULL);
>> if (err) {
>> - dev_err(dev, "failed to add mfd devices\n");
>> + dev_err(dev, "add Embedded Controller mfd device failed %d\n",
>
> Nit: As you're likely to resubmit anyway, when do do so, can you turn
> this into an English sentence?
>
> "failed to register Embedded Controller's sub-devices"
>
> ... or something.
>
Ok, I will.
Best regards,
Javier
next prev parent reply other threads:[~2015-06-05 10:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 8:05 [PATCH v6 0/8] mfd: cros_ec: Add multi EC and proto v3 support Javier Martinez Canillas
2015-06-04 8:05 ` [PATCH v6 1/8] mfd: cros_ec: Use a zero-length array for command data Javier Martinez Canillas
2015-06-04 8:05 ` [PATCH v6 2/8] mfd: cros_ec: rev cros_ec_commands.h Javier Martinez Canillas
2015-06-04 8:05 ` [PATCH v6 3/8] mfd: cros_ec: Move protocol helpers out of the MFD driver Javier Martinez Canillas
[not found] ` <1433405154-16273-1-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-06-04 8:05 ` [PATCH v6 4/8] mfd: cros_ec: add proto v3 skeleton Javier Martinez Canillas
2015-06-04 8:05 ` [PATCH v6 5/8] mfd: cros_ec: add bus-specific proto v3 code Javier Martinez Canillas
2015-06-04 8:05 ` [PATCH v6 6/8] mfd: cros_ec: Support multiple EC in a system Javier Martinez Canillas
2015-06-05 10:17 ` Lee Jones
2015-06-05 10:20 ` Javier Martinez Canillas
2015-06-08 20:46 ` Olof Johansson
2015-06-09 11:07 ` Javier Martinez Canillas
[not found] ` <1433405154-16273-7-git-send-email-javier.martinez-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2015-06-05 10:38 ` Lee Jones
2015-06-05 10:40 ` Javier Martinez Canillas [this message]
2015-06-04 8:05 ` [PATCH v6 7/8] mfd: cros_ec: spi: Add a DT property to delay asserting the CS Javier Martinez Canillas
2015-06-04 8:05 ` [PATCH v6 8/8] mfd: cros_ec: spi: Add delay for asserting CS Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55717CA1.8060503@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=amstan@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=filbranden@google.com \
--cc=gwendal@chromium.org \
--cc=gwendal@google.com \
--cc=heiko@sntech.de \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sameo@linux.intel.com \
--cc=sjg@google.com \
--cc=smbarber@chromium.org \
--cc=tbroch@chromium.org \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).