devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 15/20] ARM: dts: sun7i: Enable USB DRC on Bananapi (BROKEN!)
Date: Fri, 05 Jun 2015 21:15:09 +0200	[thread overview]
Message-ID: <5571F53D.1090104@redhat.com> (raw)
In-Reply-To: <1433530943-12599-16-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Hi,

On 05-06-15 21:02, Hans de Goede wrote:
> Enable the otg/drc usb controller on the Bananapi.
>
> This is based on the fex file settings which claim that vbus-det is
> PH5, but this does not work and the schematic shows that it is actually
> connected to gpio1 of the axp209, so we cannot add otg support for the
> bananapi until we get support for the axp209 gpio pins in the kernel.
>
> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

This one obviously should not have been part of this set, please
ignore this one.

Thanks,

Hans


> ---
>   arch/arm/boot/dts/sun7i-a20-bananapi.dts | 32 ++++++++++++++++++++++++++++++++
>   1 file changed, 32 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> index 9f7b472..ce318bf 100644
> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
> @@ -159,7 +159,25 @@
>   	status = "okay";
>   };
>
> +&otg_sram {
> +	status = "okay";
> +};
> +
>   &pio {
> +	usb0_id_detect_pin: usb0_id_detect_pin@0 {
> +		allwinner,pins = "PH4";
> +		allwinner,function = "gpio_in";
> +		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +		allwinner,pull = <SUN4I_PINCTRL_PULL_UP>;
> +	};
> +
> +	usb0_vbus_detect_pin: usb0_vbus_detect_pin@0 {
> +		allwinner,pins = "PH5";
> +		allwinner,function = "gpio_in";
> +		allwinner,drive = <SUN4I_PINCTRL_10_MA>;
> +		allwinner,pull = <SUN4I_PINCTRL_PULL_DOWN>;
> +	};
> +
>   	mmc0_cd_pin_bananapi: mmc0_cd_pin@0 {
>   		allwinner,pins = "PH10";
>   		allwinner,function = "gpio_in";
> @@ -182,6 +200,10 @@
>   	};
>   };
>
> +&reg_usb0_vbus {
> +	status = "okay";
> +};
> +
>   &reg_usb1_vbus {
>   	status = "okay";
>   };
> @@ -216,7 +238,17 @@
>   	status = "okay";
>   };
>
> +&usb_otg {
> +	dr_mode = "otg";
> +	status = "okay";
> +};
> +
>   &usbphy {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&usb0_id_detect_pin>, <&usb0_vbus_detect_pin>;
> +	usb0_id_det-gpio = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* PH4 */
> +	usb0_vbus_det-gpio = <&pio 7 5 GPIO_ACTIVE_HIGH>; /* PH5 */
> +	usb0_vbus-supply = <&reg_usb0_vbus>;
>   	usb1_vbus-supply = <&reg_usb1_vbus>;
>   	usb2_vbus-supply = <&reg_usb2_vbus>;
>   	status = "okay";
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-06-05 19:15 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-05 19:02 [PATCH 00/20] ARM: dts: Add USB and OTG related nodes and enable on various boards Hans de Goede
     [not found] ` <1433530943-12599-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-05 19:02   ` [PATCH 01/20] ARM: dts: sun4i: Add USB Dual Role Controller Hans de Goede
2015-06-05 19:02   ` [PATCH 02/20] ARM: dts: sun5i: " Hans de Goede
2015-06-05 19:02   ` [PATCH 03/20] ARM: dts: sun6i: " Hans de Goede
2015-06-05 19:02   ` [PATCH 04/20] ARM: dts: sun7i: " Hans de Goede
2015-06-05 19:02   ` [PATCH 05/20] ARM: dts: sun8i: Add A23 usb-phy and otg nodes Hans de Goede
2015-06-05 19:02   ` [PATCH 06/20] ARM: dts: sun8i: Add A33 " Hans de Goede
2015-06-05 19:02   ` [PATCH 07/20] ARM: dts: sun8i: Add support for USB controllers on A23/A33 Hans de Goede
2015-06-05 19:02   ` [PATCH 08/20] ARM: dts: sun4i: Enable USB DRC on Chuwi V7 CW0825 Hans de Goede
2015-06-05 19:02   ` [PATCH 09/20] ARM: dts: sun4i: Enable USB DRC on the Cubieboard Hans de Goede
     [not found]     ` <1433530943-12599-10-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-18 15:59       ` Maxime Ripard
2015-06-18 16:16         ` Hans de Goede
2015-06-05 19:02   ` [PATCH 10/20] ARM: dts: sun5i: Enable USB DRC on UTOO P66 Hans de Goede
2015-06-05 19:02   ` [PATCH 11/20] ARM: dts: sun6i: Enable USB DRC on the Mele A1000G quad Hans de Goede
2015-06-05 19:02   ` [PATCH 12/20] ARM: dts: sun7i: Enable USB DRC on Cubietruck Hans de Goede
2015-06-05 19:02   ` [PATCH 13/20] ARM: dts: sun7i: Enable USB DRC on A20-OLinuxIno-Lime Hans de Goede
2015-06-05 19:02   ` [PATCH 14/20] ARM: dts: sun7i: Enable USB DRC on A20-OLinuxIno-Micro Hans de Goede
2015-06-05 19:02   ` [PATCH 15/20] ARM: dts: sun7i: Enable USB DRC on Bananapi (BROKEN!) Hans de Goede
     [not found]     ` <1433530943-12599-16-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-05 19:15       ` Hans de Goede [this message]
2015-06-05 19:02   ` [PATCH 16/20] ARM: dts: sun8i: Enable USB DRC on Ippo Q8H-A23 tablets Hans de Goede
2015-06-05 19:02   ` [PATCH 17/20] ARM: dts: sun8i: Enable USB DRC on Ippo Q8H-A33 tablet Hans de Goede
2015-06-05 19:02   ` [PATCH 18/20] ARM: dts: sun8i: Enable USB DRC on GA10H-A33 tablets Hans de Goede
2015-06-05 19:02   ` [PATCH 19/20] ARM: dts: sun8i: Enable USB host " Hans de Goede
2015-06-05 19:02   ` [PATCH 20/20] ARM: dts: sun8i: sina33: Enable USB hosts Hans de Goede
2015-06-08 10:03   ` [PATCH 00/20] ARM: dts: Add USB and OTG related nodes and enable on various boards Maxime Ripard
2015-06-08 12:56     ` Michal Suchanek
     [not found]       ` <CAOMqctRDEoPiJ95EVgs_ZRQVt=SzK9NPDJGmq3JTJF1kWscmqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-06-09 20:18         ` Maxime Ripard
2015-06-10 13:27     ` Hans de Goede
     [not found]       ` <55783B2C.3080207-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-12 13:27         ` Hans de Goede
     [not found]           ` <557ADE40.70200-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-13 13:30             ` Hans de Goede
     [not found]               ` <557C308A.4010104-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-06-16  9:36                 ` Maxime Ripard
2015-06-16  9:35         ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5571F53D.1090104@redhat.com \
    --to=hdegoede-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
    --cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
    --cc=wens-jdAy2FN1RRM@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).