From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH v5 2/2] ASoC: qcom: add apq8016 sound card support Date: Tue, 09 Jun 2015 19:22:08 +0100 Message-ID: <55772ED0.2060405@linaro.org> References: <1433854702-23654-1-git-send-email-srinivas.kandagatla@linaro.org> <1433854776-23852-1-git-send-email-srinivas.kandagatla@linaro.org> <20150609170738.GI14071@sirena.org.uk> <557727BF.8040807@linaro.org> <20150609180435.GV14071@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150609180435.GV14071@sirena.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Banajit Goswami , Takashi Iwai , linux-kernel@vger.kernel.org, Patrick Lai , Liam Girdwood , Rob Herring , linux-arm-msm@vger.kernel.org, kwestfie@codeaurora.org List-Id: devicetree@vger.kernel.org On 09/06/15 19:04, Mark Brown wrote: > On Tue, Jun 09, 2015 at 06:51:59PM +0100, Srinivas Kandagatla wrote: >> On 09/06/15 18:07, Mark Brown wrote: > >>> Why not just do these one time at probe, we don't undo them when we shut >>> the DAI down? > >> If I do that Am afraid that the driver would loose the flexibility of >> selecting different MI2S from DT level. Hardcoding which MI2S can got to >> external or internal codec is something that I wanted to avoid from the >> start. > > I don't understand why we'd loose anything - we get init() callbacks on > the DAIs when they're instantiated? > Yes, got it. At dai_link init() level we can do it without losing any flexibility. My bad, I thought you initially suggested me to add this to platform probe() level. >> I will add the shutdown code to reset the configuration. > > OK. >