From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH non-pretimeout 3/7] ARM64: add SBSA Generic Watchdog device node in amd-seattle-soc.dtsi Date: Sun, 14 Jun 2015 06:57:54 -0700 Message-ID: <557D8862.8020805@roeck-us.net> References: <=fu.wei@linaro.org> <1433958452-23721-1-git-send-email-fu.wei@linaro.org> <1433958452-23721-4-git-send-email-fu.wei@linaro.org> <557B470B.9030908@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Fu Wei , Timur Tabi Cc: Suravee Suthikulpanit , Linaro ACPI Mailman List , linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Wei Fu , G Gregory , Al Stone , Hanjun Guo , Ashwin Chaugule , Arnd Bergmann , Vipul Gandhi , Wim Van Sebroeck , Jon Masters , Leo Duran , Jon Corbet , Mark Rutland , Catalin Marinas , Will Deacon , rjw@rjwysocki.net List-Id: devicetree@vger.kernel.org On 06/14/2015 03:05 AM, Fu Wei wrote: > On 13 June 2015 at 04:54, Timur Tabi wrote: >> On 06/10/2015 12:47 PM, fu.wei@linaro.org wrote: >>> >>> + reg = <0x0 0xe0bb0000 0 0x10000>, >>> + <0x0 0xe0bc0000 0 0x10000>; >> >> >> I think the sizes are wrong. They should be 0x1000 instead of 0x10000. > > This has been proved by test, it works well on Seattle > Foundation model has same value. So I don't think it is wrong > > otherwise someone has the data sheet of Seattle B0, and it shows that is wrong. > If only 0x1000 is used, why would you have to reserve 0x10000 ? You never access any higher addresses, so no matter what the datasheet says, 0x1000 should be sufficient. What matters is what the driver uses. Guenter