From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CBA8F2E635 for ; Wed, 28 Feb 2024 09:38:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709113104; cv=none; b=XbbdXVbY2rvBgqxBVDt84DQZy2Yqqz4QIPbRgZXZfi45KMsnTRXnSZf351Y9Rhv5LZZIOjFqtOEtfHMwFWVz/1bkYvC/DbUZu8RedNf7aKclcN0ZlxUfIKSpqumafoHliv4H/mYV0ggIQVoI9JQ5tP60fm+1GGrkweU60bmAtrg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709113104; c=relaxed/simple; bh=PsR1pfhQj1+YctW/5hj7cA5FYtAGn3Ht2yBzNPBY4EE=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=AHBvYPEsj1wYbaN2Q2ZsV1YXuy6efCDP4HOwDCOEGRygXu0HVTMVvTJB+51IKymYdwpsnTCKddaTNhokgtxFlEEylepgMZQj0CEGA7HKCyi8IB1+srYXxrwjM1uIs4GeUvc48fdnhdV5fPMNnnw7xbPBT/wqONAVlfWyxVIh31s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=gVi3yfe+; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gVi3yfe+" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-412a3371133so23755795e9.2 for ; Wed, 28 Feb 2024 01:38:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709113100; x=1709717900; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=n4+AKRmkmBFEoLIViqECwVqYHAu9t9L66Ay6/6CX5qk=; b=gVi3yfe+1CPYCHnSX5oOnMw9+afsQSsePxQoXFmUVM8+A9WuU73DJES0ZMQbo2Gyvp r6zv7Z2tnKpfu6cFCi0sofVQWVywqqOEPkzwsrKs10GSGz2NveIux/Q9ifDDpnsglPhS gew3zqnGI1EfjhLDi9WrJT2MdEN5HXPCcuV2Kpqh2r+jkg1Bqui5fPNqmC6LmVSf5z7L /6kfGH3Wmxxaowb+zQYntrgHRK1MZpYG5LsAzl8tSTGJuH4sDr9HWmGPokSHDnb/2D3U lnwDiHYc1vR7/hSsekFnK7uO+L1ylq+srkn+B+hEt7sy5kIwzBCvy1fmW0ecDy4qfbTc +28g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709113100; x=1709717900; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n4+AKRmkmBFEoLIViqECwVqYHAu9t9L66Ay6/6CX5qk=; b=XJJY6iqKkndAL2EVrMgyNE+AsTYl+frGjvd6On4AP8DKOXwnrwt3yywELzFBd9hr8z gBWzwpRJ8wHE4g1wJOeCDobEbxh+q8eKtPyebPBL5yrDVw8BY6ipr1b338M0ofHfwaQM 7I0HxsPaEG26mfJaSbt07WSc4y+hg5JTGX6goKJS6TBMt5Re1vOZOg4q4sr1jdqHxTI9 yBGul+EILGCb+JrVqmhvchQQ1W8hzheAyPqclajhiFu2kT24augp4tivKg85uk8mFhy0 RSCRDW1Bi6bR0braZaW1SbrF/MHyRFcO7zTmGPq9lzgsFeUZ75gcKYYggRrjLtMV9ZyQ TudQ== X-Forwarded-Encrypted: i=1; AJvYcCWPJtx9xOgwbMjBjFV5KZtNohFpYYJhRyabxTfQAHiIDKOG6a1Aj+WuuNzxqxxbjX3NKCf4Jknj+fcQ+f7EDHlyt/rINWVeGvUmLA== X-Gm-Message-State: AOJu0YwCaHYCcu0AM/lcnyCjNuDJkpAUCwxYq5HLWfdS090yZzDh3cZR +CKMLE7efo+SI9cJOhOReuaPRNZaCSgy5Hu3UIYJi7NlgQiiO3WUQvdEl64SOEE= X-Google-Smtp-Source: AGHT+IHOp1pxzWYsSZdgMk9fzN4/wRCtOOeXX9R3/XcarEOcYQuEj1WE1Pi4WYyJuSqwQHpUbVzypA== X-Received: by 2002:a05:600c:a4c:b0:412:77cb:ae28 with SMTP id c12-20020a05600c0a4c00b0041277cbae28mr10799118wmq.11.1709113100097; Wed, 28 Feb 2024 01:38:20 -0800 (PST) Received: from [172.20.10.10] ([213.233.108.239]) by smtp.gmail.com with ESMTPSA id o8-20020a056000010800b0033d202abf01sm13843461wrx.28.2024.02.28.01.38.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 01:38:19 -0800 (PST) Message-ID: <557f369c-e6f9-4794-8d80-bda5c149db5e@linaro.org> Date: Wed, 28 Feb 2024 09:38:16 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 16/39] spi: dt-bindings: atmel,at91rm9200-spi: remove 9x60 compatible from list To: Varshini.Rajendran@microchip.com, broonie@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, claudiu.beznea@tuxon.dev, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240223171342.669133-1-varshini.rajendran@microchip.com> <20240223172638.672366-1-varshini.rajendran@microchip.com> <19da0e57-379b-4db3-ba8e-db7efe336e15@linaro.org> <98fedd3f-b55d-4ad1-b2ca-1efef0a19505@microchip.com> Content-Language: en-US From: Tudor Ambarus In-Reply-To: <98fedd3f-b55d-4ad1-b2ca-1efef0a19505@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/28/24 09:28, Varshini.Rajendran@microchip.com wrote: > Hi Tudor, > > On 26/02/24 2:39 pm, Tudor Ambarus wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe >> >> On 23.02.2024 19:26, Varshini Rajendran wrote: >>> Remove microchip,sam9x60-spi compatible from the list as the driver used >>> has the compatible atmel,at91rm9200-spi and sam9x60 devices also use the >>> same compatible as fallback. So removing the microchip,sam9x60-spi >>> compatible from the list since it is not needed. >>> >> >> I find this wrong. I though we shall add compatibles for each SoC. Are >> the registers and fields the same for the SPI IPs in these 2 SoCs? Even >> if they are the same, are you sure the IPs are integrated in the same way? > > Which two SoCs are you referring to ? > I am not removing the device specific compatible. I am only removing the > additional fallback compatible. > ah, I read it wrong, sorry > As in, > > compatible = "microchip,sam9x7-spi", "atmel,at91rm9200-spi"; > > instead of, > > compatible = "microchip,sam9x7-spi", "microchip,sam9x60-spi", > "atmel,at91rm9200-spi"; > > for the sam9x7 devices. > > Hope this is clear. If I have it wrong please let me know. it's clear now, thanks. I see in the driver that microchip,sam9x60-spi compatible is not yet used, thus removing the fallback to "microchip,sam9x60-spi" brings no functional change. Would have made a difference if sam9x60-spi implemented additional support that sam9x7-spi could have used as a fallback. If you think that sam9x7-spi will not fallback to sam9x60-spi in the future then: Reviewed-by: Tudor Ambarus > >> >>> Signed-off-by: Varshini Rajendran >>> --- >>> Changes in v4: >>> - Elaborated the explanation in the commit message to justify the patch >>> --- >>> Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >>> index 58367587bfbc..32e7c14033c2 100644 >>> --- a/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >>> +++ b/Documentation/devicetree/bindings/spi/atmel,at91rm9200-spi.yaml >>> @@ -22,7 +22,6 @@ properties: >>> - const: atmel,at91rm9200-spi >>> - items: >>> - const: microchip,sam9x7-spi >>> - - const: microchip,sam9x60-spi >>> - const: atmel,at91rm9200-spi >>> >>> reg: >