From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v5 1/2] dt: add cap11xx LED documentation Date: Tue, 23 Jun 2015 10:36:20 +0200 Message-ID: <55891A84.1070509@samsung.com> References: <1434599897-22505-1-git-send-email-mranostay@gmail.com> <1434599897-22505-2-git-send-email-mranostay@gmail.com> <20150622175914.GA15851@dtor-ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <20150622175914.GA15851@dtor-ws> Sender: linux-input-owner@vger.kernel.org To: Dmitry Torokhov Cc: Matt Ranostay , zonque@gmail.com, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 06/22/2015 07:59 PM, Dmitry Torokhov wrote: > On Wed, Jun 17, 2015 at 08:58:16PM -0700, Matt Ranostay wrote: >> Signed-off-by: Matt Ranostay >> --- >> .../devicetree/bindings/input/cap11xx.txt | 25 ++++++++++++++++++++++ >> 1 file changed, 25 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/input/cap11xx.txt b/Documentation/devicetree/bindings/input/cap11xx.txt >> index 7d0a300..09cdc43 100644 >> --- a/Documentation/devicetree/bindings/input/cap11xx.txt >> +++ b/Documentation/devicetree/bindings/input/cap11xx.txt >> @@ -38,6 +38,11 @@ Optional properties: >> defaults. The array must have exactly six >> entries. >> >> + linux,led-brightness: Defines the ON brightness when the optional LED >> + functionality is used. Valid values are 1-15. >> + By default a value of 15 is set. > > Please mention the device does not allow controlling brightness of leds > individually and that is why this property is at device level, not > individual led level. I've just noticed that we have drivers/leds/leds-netxbig.c driver, which also doesn't allow controlling the LEDs on extension board individually, but it still does allow changing their brightness. I am leaning towards allowing this also for this driver and adding similar comment in the source code like at the line 218 of the aforementioned driver. As a result this property wouldn't be required. > Also, why does it have "linux" prefix? It does not appear to control > any linux-specific functionality. -- Best Regards, Jacek Anaszewski