From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jacek Anaszewski Subject: Re: [PATCH v5 1/2] dt: add cap11xx LED documentation Date: Wed, 24 Jun 2015 09:44:23 +0200 Message-ID: <558A5FD7.4060105@samsung.com> References: <1434599897-22505-1-git-send-email-mranostay@gmail.com> <1434599897-22505-2-git-send-email-mranostay@gmail.com> <20150622175914.GA15851@dtor-ws> <55891A84.1070509@samsung.com> <20150623180706.GA40168@dtor-ws> <558A5C0E.8090105@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <558A5C0E.8090105@samsung.com> Sender: linux-input-owner@vger.kernel.org To: Dmitry Torokhov Cc: Matt Ranostay , Daniel Mack , "linux-input@vger.kernel.org" , linux-leds@vger.kernel.org, "devicetree@vger.kernel.org" List-Id: devicetree@vger.kernel.org On 06/24/2015 09:28 AM, Jacek Anaszewski wrote: > On 06/23/2015 08:07 PM, Dmitry Torokhov wrote: >> On Tue, Jun 23, 2015 at 10:23:57AM -0700, Matt Ranostay wrote: >>> On Tue, Jun 23, 2015 at 1:36 AM, Jacek Anaszewski >>> wrote: >>>> On 06/22/2015 07:59 PM, Dmitry Torokhov wrote: >>>>> >>>>> On Wed, Jun 17, 2015 at 08:58:16PM -0700, Matt Ranostay wrote: >>>>>> >>>>>> Signed-off-by: Matt Ranostay >>>>>> --- >>>>>> .../devicetree/bindings/input/cap11xx.txt | 25 >>>>>> ++++++++++++++++++++++ >>>>>> 1 file changed, 25 insertions(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/input/cap11xx.txt >>>>>> b/Documentation/devicetree/bindings/input/cap11xx.txt >>>>>> index 7d0a300..09cdc43 100644 >>>>>> --- a/Documentation/devicetree/bindings/input/cap11xx.txt >>>>>> +++ b/Documentation/devicetree/bindings/input/cap11xx.txt >>>>>> @@ -38,6 +38,11 @@ Optional properties: >>>>>> defaults. The array must have >>>>>> exactly six >>>>>> entries. >>>>>> >>>>>> + linux,led-brightness: Defines the ON brightness when the >>>>>> optional LED >>>>>> + functionality is used. Valid >>>>>> values are >>>>>> 1-15. >>>>>> + By default a value of 15 is set. >>>>> >>>>> >>>>> Please mention the device does not allow controlling brightness of >>>>> leds >>>>> individually and that is why this property is at device level, not >>>>> individual led level. >>>> >>>> >>>> I've just noticed that we have drivers/leds/leds-netxbig.c driver, >>>> which >>>> also doesn't allow controlling the LEDs on extension board >>>> individually, >>>> but it still does allow changing their brightness. I am leaning towards >>>> allowing this also for this driver and adding similar comment in the >>>> source code like at the line 218 of the aforementioned driver. >>>> As a result this property wouldn't be required. >>>> >>> >>> Ok that should be pretty simple to do. But seems kind weird to have >>> each led channel to be changing the brightness of all. Wouldn't the >>> brightness sysfs entries of the other led channels be showing >>> incorrect values? > > If you implemented brightness_get op it would show proper value. > Assuming that the device allows reading current brightness. Of course brightness_get wouldn't have to read the brightness from the device, but return the value cached on on each call to brightness_set for any LED class device exposed by the driver. -- Best Regards, Jacek Anaszewski