From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kishon Vijay Abraham I Subject: Re: [PATCH 09/17] ARM: dts: dra7: Use "syscon-phy-power" instead of "ctrl-module" in SATA PHY node Date: Wed, 24 Jun 2015 19:01:03 +0530 Message-ID: <558AB117.20609@ti.com> References: <1435060743-5511-1-git-send-email-kishon@ti.com> <1435060743-5511-10-git-send-email-kishon@ti.com> <20150624150602.0e73fc8f9dda1624f22059db@ti.com> <20150624151257.fe5f1594db1afe4c1da8027d@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150624151257.fe5f1594db1afe4c1da8027d-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roger Quadros Cc: bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, balbi-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 24 June 2015 05:42 PM, Roger Quadros wrote: > On Wed, 24 Jun 2015 15:06:02 +0300 > Roger Quadros wrote: > >> On Tue, 23 Jun 2015 17:28:54 +0530 >> Kishon Vijay Abraham I wrote: >> >>> Add "syscon-phy-power" property and remove the deprecated "ctrl-module" >>> property from SATA PHY node. Since "omap_control_sata" note is no longer >>> used, remove it. >>> >>> Signed-off-by: Kishon Vijay Abraham I >> >> Acked-by: Roger Quadros > > One comment though. > >> >>> --- >>> arch/arm/boot/dts/dra7.dtsi | 10 +--------- >>> 1 file changed, 1 insertion(+), 9 deletions(-) >>> >>> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >>> index 3f434f7..92e0741 100644 >>> --- a/arch/arm/boot/dts/dra7.dtsi >>> +++ b/arch/arm/boot/dts/dra7.dtsi >>> @@ -1115,14 +1115,6 @@ >>> status = "disabled"; >>> }; >>> >>> - omap_control_sata: control-phy@4a002374 { >>> - compatible = "ti,control-phy-pipe3"; >>> - reg = <0x4a002374 0x4>; >>> - reg-names = "power"; >>> - clocks = <&sys_clkin1>; >>> - clock-names = "sysclk"; >>> - }; >>> - >>> /* OCP2SCP3 */ >>> ocp2scp@4a090000 { >>> compatible = "ti,omap-ocp2scp"; >>> @@ -1137,7 +1129,7 @@ >>> <0x4A096400 0x64>, /* phy_tx */ >>> <0x4A096800 0x40>; /* pll_ctrl */ >>> reg-names = "phy_rx", "phy_tx", "pll_ctrl"; >>> - ctrl-module = <&omap_control_sata>; >>> + syscon-phy-power = <&dra7_ctrl_core 0x374>; > > why can't we use scm_conf instead of dra7_ctrl_core? > dra7_ctrl_core seems to be redundant and wrongly placed. Agreed! Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html