From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 1/4] MIPS: BMIPS: bcm7346: add nodes for NAND Date: Wed, 24 Jun 2015 12:32:07 -0700 Message-ID: <558B05B7.8010401@gmail.com> References: <1544bf6110b43fbaa8dbb3b06a18e08ae87b386d.1435124524.git.jaedon.shin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1544bf6110b43fbaa8dbb3b06a18e08ae87b386d.1435124524.git.jaedon.shin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jaedon Shin , Ralf Baechle Cc: Kevin Cernekee , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org +Brian, On 23/06/15 23:08, Jaedon Shin wrote: > Add NAND device nodes to BMIPS based BCM7346 platform. > > Signed-off-by: Jaedon Shin > --- [snip] > + > +&nand0 { > + status = "okay"; > + > + nandcs@1 { > + compatible = "brcm,nandcs"; > + reg = <1>; > + nand-ecc-step-size = <512>; > + nand-ecc-strength = <8>; > + nand-on-flash-bbt; > + > + #size-cells = <2>; > + #address-cells = <2>; > + > + flash1.rootfs0@0 { > + reg = <0x0 0x0 0x0 0x80000000>; > + }; > + > + flash1.rootfs1@80000000 { > + reg = <0x0 0x80000000 0x0 0x80000000>; > + }; > + }; > +}; Should we create something like brcmnand-cs1-512-8 to reduce the amount of duplication between DTS files? -- Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html