From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH 1/4] MIPS: BMIPS: bcm7346: add nodes for NAND Date: Thu, 25 Jun 2015 20:00:32 -0700 Message-ID: <558CC050.6040101@gmail.com> References: <1544bf6110b43fbaa8dbb3b06a18e08ae87b386d.1435124524.git.jaedon.shin@gmail.com> <558B05B7.8010401@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jaedon Shin Cc: Ralf Baechle , Kevin Cernekee , linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org Le 06/25/15 01:52, Jaedon Shin a =C3=A9crit : >=20 >> On Jun 25, 2015, at 4:32 AM, Florian Fainelli = wrote: >> >> +Brian, >> >> On 23/06/15 23:08, Jaedon Shin wrote: >>> Add NAND device nodes to BMIPS based BCM7346 platform. >>> >>> Signed-off-by: Jaedon Shin >>> --- >> >> [snip] >> >>> + >>> +&nand0 { >>> + status =3D "okay"; >>> + >>> + nandcs@1 { >>> + compatible =3D "brcm,nandcs"; >>> + reg =3D <1>; >>> + nand-ecc-step-size =3D <512>; >>> + nand-ecc-strength =3D <8>; >>> + nand-on-flash-bbt; >>> + >>> + #size-cells =3D <2>; >>> + #address-cells =3D <2>; >>> + >>> + flash1.rootfs0@0 { >>> + reg =3D <0x0 0x0 0x0 0x80000000>; >>> + }; >>> + >>> + flash1.rootfs1@80000000 { >>> + reg =3D <0x0 0x80000000 0x0 0x80000000>; >>> + }; >>> + }; >>> +}; >> >> Should we create something like brcmnand-cs1-512-8 to reduce the amo= unt >> of duplication between DTS files? >> --=20 >> Florian >=20 > I Think that is not duplication. >=20 > I have no reference boards, but this node is maybe explaining for har= dware > description of the BCM97346DBSMB reference board. The nodes are chang= ed by > EBI CS and ECC capabilities of NAND flash. I used brcmnand-cs2-512-4 = and > brcmnand-cs1-512-4 for others. Then I am confused, your 4 patches add identical NAND flash chip properties for 7346, 7358, 7360 and 7362: CS#1, 512 bytes of ECC step size and 8 bits of ECC strength, am I missing something? --=20 =46lorian -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html