From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh shilimkar Subject: Re: [PATCH] keystone: dts: add psci command definition Date: Wed, 1 Jul 2015 08:03:05 -0700 Message-ID: <55940129.7020504@oracle.com> References: <1435752784-30639-1-git-send-email-vitalya@ti.com> <1435752784-30639-2-git-send-email-vitalya@ti.com> <20150701124101.GB2310@leverpostej> <5593E59B.9090304@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5593E59B.9090304-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Vitaly Andrianov , Mark Rutland Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org" , "ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Pawel Moll , "ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org" , "galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 7/1/2015 6:05 AM, Vitaly Andrianov wrote: > > > On 07/01/2015 08:41 AM, Mark Rutland wrote: >> On Wed, Jul 01, 2015 at 01:13:04PM +0100, Vitaly Andrianov wrote: >>> This commit adds definition for cpu_on, cpu_off and cpu_suspend >>> commands. >>> These definitions must match the corresponding PSCI definitions in >>> boot monitor. >>> >>> Signed-off-by: Vitaly Andrianov >>> --- >>> arch/arm/boot/dts/keystone.dtsi | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/keystone.dtsi >>> b/arch/arm/boot/dts/keystone.dtsi >>> index c06542b..ab60fca 100644 >>> --- a/arch/arm/boot/dts/keystone.dtsi >>> +++ b/arch/arm/boot/dts/keystone.dtsi >>> @@ -58,6 +58,14 @@ >>> ; >>> }; >>> >>> + psci { >>> + compatible = "arm,psci"; >>> + method = "smc"; >>> + cpu_suspend = <0x84000001>; >>> + cpu_off = <0x84000002>; >>> + cpu_on = <0x84000003>; >>> + }; >> >> It would be nice to have this injected automatically by the bootlaoder >> when PSCI is present, as that way users of existing systems can upgrade >> their DTB and still have things boot. >> >> Thanks, >> Mark. >> > > So, KS2 kernel doesn't need that commit and has to wait this from > u-boot? Actually PSCI support is a part of KS2 boot-monitor. U-boot is > just responsible to load and start it, but doesn't know whether PSCI is > supported. > > In any case you are right. The DTS also doesn't know whether boot- > monitor supports PSCI. It is better to make u-boot to fix up the dts. > Let's forget about this patch. I'll work on dts fix-up in u-boot. > Good. We can't break existing users as already pointed out earlier. Thanks Vitaly for following it up. Regards, Santosh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html