Re: [PATCH-V5 4/4] mfd: devicetree: bindings: Add new 88pm800 mfd binding

[Vaibhav Hiremath <vaibhav.hiremath@linaro.org>]

On Wednesday 01 July 2015 09:40 PM, Rob Herring wrote:
> On Mon, Jun 29, 2015 at 10:31 AM, Vaibhav Hiremath
> <vaibhav.hiremath@linaro.org> wrote:
>> With addition of DT support to 88pm800 mfd driver, this patch
>> adds new DT binding documentation along with respective properties.
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>
> Didn't I ack this already? You should add it when you send subsequent
> versions. The maintainer will add it if there aren't any subsequent
> versions.
>
> Acked-by: Rob Herring <robh@kernel.org>
>

Sorry Rob. Infact I did ask you as well. Probably you missed it.

Patch got changed after your ack, I did some changes based on few
review comments, from Lee and others.

Anyway, thanks for ack. Can you please queue this?

Thanks,
Vaibhav

>> ---
>>   Documentation/devicetree/bindings/mfd/88pm800.txt | 53 +++++++++++++++++++++++
>>   1 file changed, 53 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/mfd/88pm800.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/88pm800.txt b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> new file mode 100644
>> index 0000000..dec842f
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mfd/88pm800.txt
>> @@ -0,0 +1,53 @@
>> +* Marvell 88PM80x Power Management IC
>> +
>> +Required parent device properties:
>> +- compatible           : "marvell,88pm800", "marvell,88pm805", "marvell,88pm860"
>> +- reg                  : the I2C slave address for the 88pm80x family chip
>> +- interrupts           : IRQ line for the 88pm80x family chip
>> +- interrupt-controller : describes the 88pm80x family chip as an interrupt
>> +                         controller
>> +- #interrupt-cells     : should be 1.
>> +                         The cell is the 88pm80x local IRQ number
>> +
>> +88pm80x family of devices consists of varied group of sub-devices:
>> +
>> +Device                 Supply Names     Description
>> +------                 ------------     -----------
>> +88pm80x-onkey          :               : On key
>> +88pm80x-rtc            :               : RTC
>> +88pm80x-regulator      :               : Regulators
>> +
>> +Example:
>> +
>> +       pmic: 88pm800@30 {
>> +               compatible = "marvell,88pm800";
>> +               reg = <0x30>;
>> +               interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_HIGH>;
>> +               interrupt-parent = <&gic>;
>> +               interrupt-controller;
>> +               #interrupt-cells = <1>;
>> +
>> +               regulators {
>> +                       compatible = "marvell,88pm80x-regulator";
>> +
>> +                       buck1a: BUCK1A {
>> +                               regulator-name = "BUCK1A";
>> +                               regulator-min-microvolt = <600000>;
>> +                               regulator-max-microvolt = <1800000>;
>> +                               regulator-boot-on;
>> +                               regulator-always-on;
>> +                       };
>> +
>> +                       ldo1: LDO1 {
>> +                               regulator-name = "LDO1";
>> +                               regulator-min-microvolt = <1700000>;
>> +                               regulator-max-microvolt = <3300000>;
>> +                               regulator-boot-on;
>> +                               regulator-always-on;
>> +                       };
>> +               };
>> +
>> +               rtc {
>> +                       compatible = "marvell,88pm80x-rtc";
>> +               };
>> +       };
>> --
>> 1.9.1
>>