From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v5 2/3] ARM: dts: Add CPU OPP and regulator supply property for Exynos3250 Date: Thu, 02 Jul 2015 09:29:49 +0900 Message-ID: <559485FD.7030805@samsung.com> References: <1435756877-26736-1-git-send-email-cw00.choi@samsung.com> <1435756877-26736-3-git-send-email-cw00.choi@samsung.com> <55947F65.8010404@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <55947F65.8010404@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski Cc: s.nawrocki@samsung.com, tomasz.figa@gmail.com, mturquette@baylibre.com, sboyd@codeaurora.org, kgene@kernel.org, thomas.ab@samsung.com, b.zolnierkie@samsung.com, kyungmin.park@samsung.com, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org On 07/02/2015 09:01 AM, Krzysztof Kozlowski wrote: > On 01.07.2015 22:21, Chanwoo Choi wrote: >> This patch add CPU operating points which include CPU frequency and regulator >> voltage to use generic cpufreq drivers. >> >> Cc: Kukjin Kim >> Cc: Krzysztof Kozlowski >> Signed-off-by: Chanwoo Choi >> Acked-by: Kyungmin Park >> --- >> arch/arm/boot/dts/exynos3250-monk.dts | 4 ++++ >> arch/arm/boot/dts/exynos3250-rinato.dts | 4 ++++ >> arch/arm/boot/dts/exynos3250.dtsi | 15 +++++++++++++++ >> 3 files changed, 23 insertions(+) > > The patch looks good. Could you put the 'cpu' nodes in alphabetical > order? The order for Rinato board is already broken but still putting it > after 'adc' node would be better. > > With the change above: > Reviewed-by: Krzysztof Kozlowski OK. I'll resend it. Thanks, Chanwoo Choi