devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Richard Cochran <richardcochran@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Cc: linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	Alan Tull <atull@altera.com>,
	Alexandre Courbot <gnurou@gmail.com>,
	Dinh Nguyen <dinguyen@altera.com>,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH 1/2] gpio: dwapb: Use human understandable gpio numbering.
Date: Thu, 02 Jul 2015 09:36:22 +0200	[thread overview]
Message-ID: <5594E9F6.7040701@linutronix.de> (raw)
In-Reply-To: <d6b5ce85a17164970d454583560e07f7aed7b8ca.1435777856.git.rcochran@linutronix.de>

On 07/01/2015 09:34 PM, Richard Cochran wrote:
> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
> index 58faf04..b7e7977 100644
> --- a/drivers/gpio/gpio-dwapb.c
> +++ b/drivers/gpio/gpio-dwapb.c
> @@ -491,6 +491,13 @@ dwapb_gpio_get_pdata_of(struct device *dev)
>  			return ERR_PTR(-EINVAL);
>  		}
>  
> +		if (of_property_read_u32(port_np, "snps,base",
> +					 &pp->gpio_base)) {
> +			dev_info(dev, "no base gpio specified for %s\n",
> +				 port_np->full_name);
> +			pp->gpio_base = -1;
> +		}
> +

If you are in a specific SoC you could do
	base = of_alias_get_id(np, "gpio") * num_of_gpio_per_chip
and get consistent numbers / sane.
I think this is the one reason why there is no generic binding for the
starting address. The other reason might be that this is simply a user
space problem. To get consistent numbers all you need to do to lookup
each gpio's memory address and decide if this is the one you look for.

Sebastian

  parent reply	other threads:[~2015-07-02  7:36 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 19:34 [PATCH 0/2] gpio: dwapb: allow sane gpio numbering Richard Cochran
2015-07-01 19:34 ` [PATCH 1/2] gpio: dwapb: Use human understandable " Richard Cochran
2015-07-02  7:05   ` Michael van der Westhuizen
2015-07-02 14:20     ` Richard Cochran
     [not found]       ` <20150702142058.GA9349-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-07-16  7:57         ` Linus Walleij
2015-07-16  8:18           ` Michael van der Westhuizen
2015-07-16 18:19           ` Richard Cochran
2015-07-03  9:13     ` Richard Cochran
2015-07-03  9:18       ` Michael van der Westhuizen
     [not found]         ` <C1BD6DA3-F32E-4CAD-8DA9-6F74A7966DBE-XrNoQAPr3WXM9gW82pYGhQ@public.gmane.org>
2015-07-03 10:36           ` Richard Cochran
2015-07-03 10:55             ` Russell King - ARM Linux
2015-07-16  7:52     ` Linus Walleij
2015-07-16  8:16       ` Michael van der Westhuizen
2015-07-02  7:36   ` Sebastian Andrzej Siewior [this message]
2015-07-02 14:26     ` Richard Cochran
2015-07-02 14:30       ` Sebastian Andrzej Siewior
     [not found]         ` <55954B17.3020303-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-07-02 15:21           ` Richard Cochran
     [not found]             ` <20150702152147.GA10111-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-07-02 15:54               ` Sebastian Andrzej Siewior
2015-07-02 16:02                 ` Michael van der Westhuizen
2015-07-03 13:30                   ` Michael van der Westhuizen
     [not found]   ` <d6b5ce85a17164970d454583560e07f7aed7b8ca.1435777856.git.rcochran-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-07-16  7:50     ` Linus Walleij
2015-07-16 17:10       ` Richard Cochran
2015-07-16 17:19       ` Richard Cochran
2015-07-27 10:19         ` Linus Walleij
2015-07-27 11:28           ` Richard Cochran
2015-07-27 12:26           ` Sebastian Andrzej Siewior
     [not found] ` <cover.1435777856.git.rcochran-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-07-01 19:34   ` [PATCH 2/2] arm: dts: socfpga: Provide the gpio numbers in the controller nodes Richard Cochran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5594E9F6.7040701@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=atull@altera.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dinguyen@altera.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).