From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyrille Pitchen Subject: Re: [PATCH v3 2/4] tty/serial: at91: fix some macro definitions to fit coding style Date: Thu, 2 Jul 2015 15:36:49 +0200 Message-ID: <55953E71.4070109@atmel.com> References: <9f0f19d2fe05ea95572b467ec49ecd11389e3be9.1435672649.git.cyrille.pitchen@atmel.com> <11308515.NsBzDiA1lH@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <11308515.NsBzDiA1lH@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann Cc: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, wenyou.yang-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, ludovic.desroches-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, leilei.zhao-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, josh.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org, alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, julia.lawall-L2FTfq7BK8M@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Arnd, I've just sent a new series of patches to remove all those macros. By the way, the patch dedicated to this update was created using coccin= elle. Based on Alexandre comment, I leave __raw_writel() and __raw_readl() fo= r now. Best Regards, Cyrille Le 30/06/2015 22:28, Arnd Bergmann a =E9crit : > On Tuesday 30 June 2015 16:05:15 Cyrille Pitchen wrote: >> +#define UART_PUT_CR(port, v) __raw_writel(v, (port)->membase + AT= MEL_US_CR) >> +#define UART_GET_MR(port) __raw_readl((port)->membase + ATMEL_= US_MR) >> +#define UART_PUT_MR(port, v) __raw_writel(v, (port)->membase + AT= MEL_US_MR) >> +#define UART_PUT_IER(port, v) __raw_writel(v, (port)->membase + AT= MEL_US_IER) >> >=20 > How about removing these macros entirely? I'm not aware of other driv= ers > doing it like this, and it does not seem to add any value? >=20 > At the same time, you could use readl_relaxed() to make the driver > endian-safe. >=20 > Arnd >=20 -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html