From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCH 7/9] iio: mma8452: change iio event type to IIO_EV_TYPE_MAG Date: Sun, 05 Jul 2015 12:50:13 +0100 Message-ID: <559919F5.8070107@kernel.org> References: <1436018110-3903-1-git-send-email-martink@posteo.de> <1436018110-3903-8-git-send-email-martink@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436018110-3903-8-git-send-email-martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Martin Kepplinger , knaack.h-Mmb7MZpHnFY@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, mfuzzey-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org, roberta.dobrescu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Martin Kepplinger List-Id: devicetree@vger.kernel.org On 04/07/15 14:55, Martin Kepplinger wrote: > IIO_EV_TYPE_THRESH in rising direction describes an event where the > threshold is crossed in rising direction, positive or negative values > being possible. This is not the case here. > > Since the threshold is no signed value and only the magnitude is compared, > IIO_EV_TYPE_MAG is what describes the behaviour of these devices, see the > sysfs-bus-iio ABI Documentation. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Christoph Muellner This is a fix and so should have been the first patch in the series. It will want to go via a different tree (iio-fixes) and probably be marked for stable. I would however like Peter's ack on this as well before taking it. > --- > drivers/iio/accel/mma8452.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c > index 7f6e3b4..e23ebd0 100644 > --- a/drivers/iio/accel/mma8452.c > +++ b/drivers/iio/accel/mma8452.c > @@ -598,21 +598,21 @@ static void mma8452_transient_interrupt(struct iio_dev *indio_dev) > if (src & data->chip_info->ev_src_xe) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_X, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & data->chip_info->ev_src_ye) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Y, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > > if (src & data->chip_info->ev_src_ze) > iio_push_event(indio_dev, > IIO_MOD_EVENT_CODE(IIO_ACCEL, 0, IIO_MOD_Z, > - IIO_EV_TYPE_THRESH, > + IIO_EV_TYPE_MAG, > IIO_EV_DIR_RISING), > ts); > } > @@ -689,7 +689,7 @@ static int mma8452_reg_access_dbg(struct iio_dev *indio_dev, > > static const struct iio_event_spec mma8452_transient_event[] = { > { > - .type = IIO_EV_TYPE_THRESH, > + .type = IIO_EV_TYPE_MAG, > .dir = IIO_EV_DIR_RISING, > .mask_separate = BIT(IIO_EV_INFO_ENABLE), > .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | > @@ -700,7 +700,7 @@ static const struct iio_event_spec mma8452_transient_event[] = { > > static const struct iio_event_spec mma8452_motion_event[] = { > { > - .type = IIO_EV_TYPE_THRESH, > + .type = IIO_EV_TYPE_MAG, > .dir = IIO_EV_DIR_RISING, > .mask_separate = BIT(IIO_EV_INFO_ENABLE), > .mask_shared_by_type = BIT(IIO_EV_INFO_VALUE) | >