From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
Kukjin Kim <kgene@kernel.org>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes
Date: Wed, 08 Jul 2015 17:27:06 +0900 [thread overview]
Message-ID: <559CDEDA.50608@samsung.com> (raw)
In-Reply-To: <1436333790-18219-1-git-send-email-javier@osg.samsung.com>
On 08.07.2015 14:36, Javier Martinez Canillas wrote:
> Hello Kukjin and Krzysztof,
>
> This is a trivial series that changes Exynos5 pinctrl dtsi files to extend
> the pinctrl nodes using labels instead of full paths.
>
> Using labels is less error prone since a misstyped label leads to a build
> error while full paths can lead to the creation of a new node instead of
> overriding the original which makes the mistake harder to detect.
>
> I tested the changes by decompiling the Exynos5* dtbs and comparing before
> and after. The resulting dts were identical modulo some node ordering due
> the pinctrl include change.
Is the DTB before and after the same? It should not change by re-ordering.
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-07-08 8:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 5:36 [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes Javier Martinez Canillas
2015-07-08 5:36 ` [PATCH 1/4] ARM: dts: Include exynos5250-pinctrl after the nodes were defined Javier Martinez Canillas
2015-07-08 8:24 ` Krzysztof Kozlowski
2015-07-08 5:36 ` [PATCH 2/4] ARM: dts: Extend exynos5250-pinctrl nodes using labels instead of paths Javier Martinez Canillas
2015-07-08 8:29 ` Krzysztof Kozlowski
[not found] ` <559CDF66.6080609-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-08 14:05 ` Javier Martinez Canillas
2015-07-08 23:53 ` Krzysztof Kozlowski
2015-07-08 5:36 ` [PATCH 3/4] ARM: dts: Include exynos5420-pinctrl after the nodes were defined Javier Martinez Canillas
2015-07-08 8:25 ` Krzysztof Kozlowski
2015-07-08 8:27 ` Krzysztof Kozlowski [this message]
[not found] ` <559CDEDA.50608-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2015-07-08 14:15 ` [PATCH 0/4] ARM: dts: Use labels instead of full paths for Exynos5 pinctrl nodes Javier Martinez Canillas
2015-07-08 23:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559CDEDA.50608@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).