From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v2 2/2] clk: mediatek: Add MT8173 MMPLL change rate support Date: Wed, 08 Jul 2015 17:46:02 -0700 Message-ID: <559DC44A.1030900@codeaurora.org> References: <1436344666-25645-1-git-send-email-jamesjj.liao@mediatek.com> <1436344666-25645-3-git-send-email-jamesjj.liao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1436344666-25645-3-git-send-email-jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: James Liao , Matthias Brugger , Mike Turquette , Heiko Stubner Cc: srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Daniel Kurtz , Ricky Liang , Rob Herring , Sascha Hauer , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 07/08/2015 01:37 AM, James Liao wrote: > diff --git a/drivers/clk/mediatek/clk-pll.c b/drivers/clk/mediatek/clk-pll.c > index 68af518..622e7b6 100644 > --- a/drivers/clk/mediatek/clk-pll.c > +++ b/drivers/clk/mediatek/clk-pll.c > @@ -138,16 +138,28 @@ static void mtk_pll_calc_values(struct mtk_clk_pll *pll, u32 *pcw, u32 *postdiv, > u32 freq, u32 fin) > { > unsigned long fmin = 1000 * MHZ; > + const struct mtk_pll_div_table *div_table = pll->data->div_table; > u64 _pcw; > u32 val; > > if (freq > pll->data->fmax) > freq = pll->data->fmax; > > - for (val = 0; val < 4; val++) { > + if (div_table) { > + if (freq > div_table[0].freq) > + freq = div_table[0].freq; > + > + for (val = 0; div_table[val + 1].freq != 0; val++) { > + if (freq > div_table[val + 1].freq) > + break; > + } > *postdiv = 1 << val; > - if (freq * *postdiv >= fmin) > - break; > + } else { > + for (val = 0; val < 5; val++) { > + *postdiv = 1 << val; > + if ((u64)freq * *postdiv >= fmin) > No mention of this cast in the commit text. Is this fixing a bug? If so, please mention it and/or split this bug fix off of this patch. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html