From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 4/7] tty: 8250: omap eliminate use of of_machine_is_compatible() Date: Thu, 9 Jul 2015 16:48:12 +0530 Message-ID: <559E5874.3040307@ti.com> References: <559DB989.1040501@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <559DB989.1040501-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Peter Hurley , Greg Kroah-Hartman , Tony Lindgren Cc: Linux OMAP Mailing List , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Device Tree Mailing List , John Ogness , Sebastian Andrzej Siewior , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Peter, On Thursday 09 July 2015 05:30 AM, Peter Hurley wrote: > Hi Sekhar, > > On 07/06/2015 05:47 AM, Sekhar Nori wrote: >> Use of of_machine_is_compatible() for AM335x specific DMA >> quirk in 8250_omap driver makes it ugly to extend the >> quirk for other platforms. Instead use a new compatible. >> >> The new compatible will also make it easier to care of other >> quirks specific to AM335x and like SoCs. >> >> This patch does break backward DTB compatibility for users of >> 8250_omap driver on AM335x boards. > > Not ok. > > 8250_omap was released with 3.19 and has been the default driver for > BeagleBone since 4.0. Alright, I guess I was really stretching my luck here. Will keep the of_machine_is_compatible() around so there should be no backward compatibility issue. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html